Skip to content

util/vfio-helpers: Add support for multiple IRQs

Philippe Mathieu-Daudé qemu-devel 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest4 patches 8 repliesIn review
  2. v5 RFC4 patches 4 repliesSuperseded
  3. v4 RFC5 patches 2 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v3 RFC5 patches5 repliesSuperseded
v2 RFC7 patches4 repliesSuperseded
v1 RFC3 patches3 repliesSuperseded

Changes in v6 from the cover letter

- addressed Fam review comment (return EINVAL)
- addressed Fam R-b tags
- no more RFC :)

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4util/vfio-helpers: Improve reporting unsupported IOMMU typeutil/vfio-helpers.c+1 -11 reply
2/4util/vfio-helpers: Report error when IOMMU page size is not supportedutil/vfio-helpers.c+20 -01 reply
3/4util/vfio-helpers: Introduce qemu_vfio_pci_init_msix_irqs()include/qemu/vfio-helpers.h util/vfio-helpers.c+69 -25 replies
4/4block/nvme: Use qemu_vfio_pci_init_msix_irqs() to initialize our IRQblock/nvme.c+7 -21 reply

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchFam ZhengStefan Hajnoczi
1/4R-b R-b
2/4R-b R-b
3/4R-b
4/4R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 0/4] util/vfio-helpers: Add support for multiple IRQs

This series intends to setup the VFIO helper to allow binding notifiers on different IRQs.

For the NVMe use case, we only care about MSIX interrupts. To not disrupt other users, introduce the qemu_vfio_pci_init_msix_irqs function to initialize multiple MSIX IRQs and attach eventfd to them.

Since RFC v5:
- addressed Fam review comment (return EINVAL)
- addressed Fam R-b tags
- no more RFC :)

Since RFC v4:
- addressed Alex review comment:
check ioctl(VFIO_DEVICE_SET_IRQS) return value

Since RFC v3:
- addressed Alex and Stefan review comments

Since RFC v2:
- new patch to report vfio-helpers is not supported on AA64/POWER

(NVMe block driver series will follow).

Based-on: <[email protected]> (Block layer pending pull request)

Philippe Mathieu-Daudé (4):
util/vfio-helpers: Improve reporting unsupported IOMMU type util/vfio-helpers: Report error when IOMMU page size is not supported util/vfio-helpers: Introduce qemu_vfio_pci_init_msix_irqs() block/nvme: Use qemu_vfio_pci_init_msix_irqs() to initialize our IRQ

 include/qemu/vfio-helpers.h |  6 ++-
 block/nvme.c                |  9 +++-
 util/vfio-helpers.c         | 87 ++++++++++++++++++++++++++++++++++++-
 3 files changed, 97 insertions(+), 5 deletions(-)
Signature · 1 line
2.26.2