Skip to content

mm/debug_vm_pgtable fixes

Aneesh Kumar K.V linux-mm linux-riscv linux-s390 linux-snps-arc linuxppc-dev 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest13 patches 35 repliesIn review 12 of 14 applied
  2. v313 patches 36 repliesSuperseded
  3. v213 patches 18 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v116 patches27 repliesSuperseded

Changes in v4 from the cover letter

* Address review feedback
* Move page table depost and withdraw patch after adding pmdlock to avoid bisect failure.

Patches in v4 12 of 14 applied

#Subject and filesSizeRepliesApplied
1/13powerpc/mm: Add DEBUG_VM WARN for pmd_cleararch/powerpc/include/asm/book3s/64/pgtable.h+14 -00 repliesApplied
2/13powerpc/mm: Move setting pte specific flags to pfn_ptearch/powerpc/include/asm/book3s/64/pgtable.h arch/powerpc/include/asm/nohash/pgtable.h arch/powerpc/mm/pgtable.c+9 -161 replyApplied
3/13mm/debug_vm_pgtable/ppc64: Avoid setting top bits in radom valuemm/debug_vm_pgtable.c+10 -31 replyApplied
4/13mm/debug_vm_pgtables/hugevmap: Use the arch helper to identify huge vmap support.mm/debug_vm_pgtable.c+12 -23 repliesApplied
5/13mm/debug_vm_pgtable/savedwrite: Enable savedwrite test with CONFIG_NUMA_BALANCINGmm/debug_vm_pgtable.c+9 -21 replyApplied
6/13mm/debug_vm_pgtable/THP: Mark the pte entry huge before using set_pmd/pud_atmm/debug_vm_pgtable.c+11 -91 reply
7/13mm/debug_vm_pgtable/set_pte/pmd/pud: Don't use set_*_at to update an existing pte entrymm/debug_vm_pgtable.c+15 -201 replyApplied
8/13mm/debug_vm_pgtable/locks: Move non page table modifying test togethermm/debug_vm_pgtable.c+28 -231 replyApplied
9/13mm/debug_vm_pgtable/locks: Take correct page table lockmm/debug_vm_pgtable.c+22 -131 replyApplied
10/13mm/debug_vm_pgtable/thp: Use page table depost/withdraw with THPmm/debug_vm_pgtable.c+7 -31 replyApplied
11/13mm/debug_vm_pgtable/pmd_clear: Don't use pmd/pud_clear on pte entriesmm/debug_vm_pgtable.c+4 -31 replyApplied
12/13mm/debug_vm_pgtable/hugetlb: Disable hugetlb test on ppc64mm/debug_vm_pgtable.c+4 -01 replyApplied
13/13mm/debug_vm_pgtable: Avoid none pte in pte_clear_testmm/debug_vm_pgtable.c+4 -35 repliesApplied
13/13mm/debug_vm_pgtable: Avoid none pte in pte_clear_testmm/debug_vm_pgtable.c+4 -31 reply

Reviews trailers per patch

9 of 14 patches have a Reviewed-by or Acked-by.

PatchChristophe LeroyAnshuman Khandual
1/13
2/13R-b
3/13R-b
4/13R-b
5/13R-b
6/13R-b
7/13R-b
8/13
9/13
10/13R-b
11/13
12/13
13/13R-b
13/13R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 00/13] mm/debug_vm_pgtable fixes

This patch series includes fixes for debug_vm_pgtable test code so that they follow page table updates rules correctly. The first two patches introduce changes w.r.t ppc64. The patches are included in this series for completeness. We can merge them via ppc64 tree if required.

Hugetlb test is disabled on ppc64 because that needs larger change to satisfy page table update rules.

These tests are broken w.r.t page table update rules and results in kernel crash as below.

[   21.083519] kernel BUG at arch/powerpc/mm/pgtable.c:304!
cpu 0x0: Vector: 700 (Program Check) at [c000000c6d1e76c0]
    pc: c00000000009a5ec: assert_pte_locked+0x14c/0x380
    lr: c0000000005eeeec: pte_update+0x11c/0x190
    sp: c000000c6d1e7950

msr: 8000000002029033
current = 0xc000000c6d172c80
paca = 0xc000000003ba0000 irqmask: 0x03 irq_happened: 0x01
pid = 1, comm = swapper/0
kernel BUG at arch/powerpc/mm/pgtable.c:304!
[link register ] c0000000005eeeec pte_update+0x11c/0x190
[c000000c6d1e7950] 0000000000000001 (unreliable) [c000000c6d1e79b0] c0000000005eee14 pte_update+0x44/0x190 [c000000c6d1e7a10] c000000001a2ca9c pte_advanced_tests+0x160/0x3d8 [c000000c6d1e7ab0] c000000001a2d4fc debug_vm_pgtable+0x7e8/0x1338 [c000000c6d1e7ba0] c0000000000116ec do_one_initcall+0xac/0x5f0 [c000000c6d1e7c80] c0000000019e4fac kernel_init_freeable+0x4dc/0x5a4 [c000000c6d1e7db0] c000000000012474 kernel_init+0x24/0x160 [c000000c6d1e7e20] c00000000000cbd0 ret_from_kernel_thread+0x5c/0x6c

With DEBUG_VM disabled

[   20.530152] BUG: Kernel NULL pointer dereference on read at 0x00000000
[   20.530183] Faulting instruction address: 0xc0000000000df330
cpu 0x33: Vector: 380 (Data SLB Access) at [c000000c6d19f700]
    pc: c0000000000df330: memset+0x68/0x104
    lr: c00000000009f6d8: hash__pmdp_huge_get_and_clear+0xe8/0x1b0
    sp: c000000c6d19f990

msr: 8000000002009033
dar: 0
current = 0xc000000c6d177480
paca = 0xc00000001ec4f400 irqmask: 0x03 irq_happened: 0x01
pid = 1, comm = swapper/0
[link register ] c00000000009f6d8 hash__pmdp_huge_get_and_clear+0xe8/0x1b0
[c000000c6d19f990] c00000000009f748 hash__pmdp_huge_get_and_clear+0x158/0x1b0 (unreliable) [c000000c6d19fa10] c0000000019ebf30 pmd_advanced_tests+0x1f0/0x378 [c000000c6d19fab0] c0000000019ed088 debug_vm_pgtable+0x79c/0x1244 [c000000c6d19fba0] c0000000000116ec do_one_initcall+0xac/0x5f0 [c000000c6d19fc80] c0000000019a4fac kernel_init_freeable+0x4dc/0x5a4 [c000000c6d19fdb0] c000000000012474 kernel_init+0x24/0x160 [c000000c6d19fe20] c00000000000cbd0 ret_from_kernel_thread+0x5c/0x6c

Changes from v3:
* Address review feedback
* Move page table depost and withdraw patch after adding pmdlock to avoid bisect failure.

Changes from v2:
* Fix build failure with different configs and architecture.

Changes from v1:
* Address review feedback
* drop test specific pfn_pte and pfn_pmd.
* Update ppc64 page table helper to add _PAGE_PTE

Aneesh Kumar K.V (13):
powerpc/mm: Add DEBUG_VM WARN for pmd_clear
powerpc/mm: Move setting pte specific flags to pfn_pte mm/debug_vm_pgtable/ppc64: Avoid setting top bits in radom value mm/debug_vm_pgtables/hugevmap: Use the arch helper to identify huge
vmap support.
mm/debug_vm_pgtable/savedwrite: Enable savedwrite test with
CONFIG_NUMA_BALANCING
mm/debug_vm_pgtable/THP: Mark the pte entry huge before using
set_pmd/pud_at
mm/debug_vm_pgtable/set_pte/pmd/pud: Don't use set_*_at to update an
existing pte entry
mm/debug_vm_pgtable/locks: Move non page table modifying test together mm/debug_vm_pgtable/locks: Take correct page table lock mm/debug_vm_pgtable/thp: Use page table depost/withdraw with THP mm/debug_vm_pgtable/pmd_clear: Don't use pmd/pud_clear on pte entries mm/debug_vm_pgtable/hugetlb: Disable hugetlb test on ppc64 mm/debug_vm_pgtable: Avoid none pte in pte_clear_test

 arch/powerpc/include/asm/book3s/64/pgtable.h |  29 +++-
 arch/powerpc/include/asm/nohash/pgtable.h    |   5 -
 arch/powerpc/mm/pgtable.c                    |   5 -
 mm/debug_vm_pgtable.c                        | 171 ++++++++++++-------
 4 files changed, 131 insertions(+), 79 deletions(-)
Signature · 1 line
2.26.2