Skip to content

multipath-tools series part VII: addional patches

[email protected] dm-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 of 87 patches 5 repliesIn review
  2. v24 of 84 patches 5 repliesSuperseded

4 of 87 patches are in this archive. The cover letter announces 87.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
84/87libmultipath: add consistency check for alias settingslibmultipath/alias.c libmultipath/alias.h multipath/main.c +1 more+274 -01 reply
85/87libmultipath: alias.c: use strtok_r() instead of strtok()libmultipath/alias.c+10 -101 reply
86/87libmultipath: adopt_paths(): set pp->mpp only on successlibmultipath/structs_vec.c+9 -61 reply
87/87libmultipath: fix a -Wformat-truncation warning from gcc 10libmultipath/util.c+3 -32 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchBenjamin Marzinski
84/87R-b
85/87R-b
86/87R-b
87/87R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 00/87] multipath-tools series part VII: addional patches

From: Martin Wilck <[email protected]>

This is v3 of part VII of a larger patch series for multipath-tools I've been preparing. It's based on the previously submitted part VI.

The full series will also be available here:
https://github.com/mwilck/multipath-tools/tree/ups/submit-200819
This part is tagged "submit-200819-7".

This part contains patches added since the v1 and v2 submissions of the series. One is Liu's fix for disassemble_map(), rebased on top of my previous changes to that function.

84/87, related to inconsistent alias settings, belongs logically to part III. I couldn't add it there because it would have changed the numbering in the series wrt v1, which I wanted to avoid.

Changes v2 -> v3, as suggested by Ben Marzinski:

84/87 "libmultipath: add consistency check for alias settings"
- fixed possible freeing of NULL pointer
- search vector backwards in add_binding()
- avoid fd leak in check_alias_settings()

85/87 "libmultipath: alias.c: use strtok_r() instead of strtok()"
- new, provide thread safety in alias.c

86/87 "libmultipath: adopt_paths(): set pp->mpp only on success"
- new, implement Ben's suggestion in his review of patch 54 in the v2 series ("[PATCH v2 44/54] libmultipath: adopt_paths(): don't bail out on single path failure")

Besides, a trivial warning fix was added (87/87).

Martin Wilck (6):
multipath: check_path_valid(): eliminate some failure modes
libmultipath: alias: static const variable for BINDINGS_FILE_HEADER
libmultipath: add consistency check for alias settings
libmultipath: alias.c: use strtok_r() instead of strtok()
libmultipath: adopt_paths(): set pp->mpp only on success
libmultipath: fix a -Wformat-truncation warning from gcc 10

Zhiqiang Liu (1):
libmultipath: free pp if store_path fails in disassemble_map

 libmultipath/alias.c       | 294 +++++++++++++++++++++++++++++++++++--
 libmultipath/alias.h       |  15 +-
 libmultipath/dmparser.c    |  12 +-
 libmultipath/structs_vec.c |  15 +-
 libmultipath/util.c        |   6 +-
 multipath/main.c           |  21 +--
 multipathd/main.c          |   3 +
 7 files changed, 327 insertions(+), 39 deletions(-)
Signature · 1 line
2.28.0