Skip to content

fs/squashfs: Add new decompression algorithms

Tom Rini u-boot 1 version New

Get series with b4
b4 am 20200812153357.GL20605@bill-the-cat

Versions newest first

  1. v1 Latest0 of 2 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 2 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] fs/squashfs: Add new decompression algorithms
Quoted 24 lines · Joao Marcos Costa
Quoted 12 lines · On Tue, 11 Aug 2020 11:13:41 -0400 Tom Rini <[email protected]> wrote:
Quoted 10 lines · Joao Marcos Costa

Hello,

Following the SquashFS support, this series adds support for LZO and ZSTD algorithms. The only compression type enabled by default is ZLIB, so LZO and ZSTD need to be manually selected.

Joao Marcos Costa (2):
fs/squashfs: add support for LZO decompression
fs/squashfs: add support for ZSTD decompression

Quoted 6 lines
Quoted 3 lines
 fs/squashfs/sqfs_decompressor.c | 60

+++++++++++++++++++++++++++++++-- 1 file changed, 58 insertions(+), 2 deletions(-)

Can we add tests for this to sandbox? Thanks!

Hello,

Quoted 7 lines

Is there any way to check the package version with the python API? I already use 'requiredtool' marker, but apparently it is not enough. My host machine (Ubuntu 18.04) has mksquashfs at its version 4.3, without zstd support. However, v4.4 has such support, and I had to download it and build it myself to use zstd compression. The tests will fail if the user has an older version of mksquashfs installed. Would you have any suggestion on how to proceed?

This sounds like the cases where we have to build the tools we need. There's an example in .travis.yml for QEMU already, and we use
https://gitlab.denx.de/u-boot/gitlab-ci-runner/ for Azure/GitLab. Testing those with your own container does require setting up an Azure account or using your own GitLab + runner.

That said, if you unit test things and are confident it won't blow up when I test it, that can be good enough. Thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200812/957e2d3f/attachment.sig>