Skip to content

kbuild: clang-tidy

Masahiro Yamada linux-kbuild lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest10 patches 3 repliesIn review
  2. v29 patches 13 repliesSuperseded
  3. v13 patches 11 repliesSuperseded

Changes in v3 from the cover letter

Fix minor mistakes pointed out by Nick
Add a new patch (09/10) to remove the warning about too few .cmd files.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10gen_compile_commands: parse only the first line of .*.cmd filesscripts/gen_compile_commands.py+2 -50 replies
2/10gen_compile_commands: use choices for --log_levels optionscripts/gen_compile_commands.py+4 -100 replies
3/10gen_compile_commands: do not support .cmd files under tools/ directoryscripts/gen_compile_commands.py+12 -200 replies
4/10gen_compile_commands: reword the help message of -d optionscripts/gen_compile_commands.py+2 -20 replies
5/10gen_compile_commands: make -o option independent of -d optionscripts/gen_compile_commands.py+9 -90 replies
6/10gen_compile_commands: move directory walk to a generator functionscripts/gen_compile_commands.py+32 -120 replies
7/10gen_compile_commands: support *.o, *.a, modules.order in positional argumentscripts/gen_compile_commands.py+96 -41 reply
8/10kbuild: wire up the build rule of compile_commands.json to MakefileMakefile+25 -40 replies
9/10gen_compile_commands: remove the warning about too few .cmd filesscripts/gen_compile_commands.py+0 -101 reply
10/10Makefile: Add clang-tidy and static analyzer support to makefileMAINTAINERS Makefile scripts/clang-tools/gen_compile_commands.py +1 more+93 -20 replies

Reviews trailers per patch

All 10 patches have a Reviewed-by or Acked-by.

PatchNick DesaulniersLukas Bulwahn
1/10R-b T-b
2/10R-b
3/10R-b
4/10R-b
5/10R-b
6/10R-b
7/10R-b
8/10A-b
9/10R-b
10/10R-b T-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 00/10] kbuild: clang-tidy

I improved gen_compile_commands.py,
then rebased Nathan's v7 [1] on top of them.
To save time, I modified the Makefile part.
No change for run-clang-tools.py

"make clang-tidy" should work in-tree build, out-of-tree build (O=), and external module build (M=).

V3:
Fix minor mistakes pointed out by Nick
Add a new patch (09/10) to remove the warning about too few .cmd files.

V2:
Keep the previous work-flow.
You can still manually run scripts/gen_compile_commands.json

'make compile_commands.json' or 'make clang-tidy' is handier for most cases. As Nick noted, there is 3 % loss of the coverage.

If you need the full compilation database that covers all the compiled C files, please run the script manually.

[1] https://patchwork.kernel.org/patch/11687833/

Masahiro Yamada (9):
gen_compile_commands: parse only the first line of .*.cmd files
gen_compile_commands: use choices for --log_levels option
gen_compile_commands: do not support .cmd files under tools/ directory
gen_compile_commands: reword the help message of -d option
gen_compile_commands: make -o option independent of -d option
gen_compile_commands: move directory walk to a generator function
gen_compile_commands: support *.o, *.a, modules.order in positional
argument
kbuild: wire up the build rule of compile_commands.json to Makefile
gen_compile_commands: remove the warning about too few .cmd files

Nathan Huckleberry (1):
Makefile: Add clang-tidy and static analyzer support to makefile

 MAINTAINERS                                 |   1 +
 Makefile                                    |  45 +++-
 scripts/clang-tools/gen_compile_commands.py | 236 ++++++++++++++++++++
 scripts/clang-tools/run-clang-tools.py      |  74 ++++++
 scripts/gen_compile_commands.py             | 151 -------------
 5 files changed, 352 insertions(+), 155 deletions(-)
 create mode 100755 scripts/clang-tools/gen_compile_commands.py
 create mode 100755 scripts/clang-tools/run-clang-tools.py
 delete mode 100755 scripts/gen_compile_commands.py
Signature · 1 line
2.25.1