increase msgrcv coverage
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest3 patches 0 repliesNew
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | syscalls/msgrcv: Add check for msg_lrpid and msg_rtime | +0 | 0 replies | |
| 2/3 | syscalls/msgrcv07: Add different msgtyp test | +0 | 2 replies | |
| 3/3 | syscalls/msgrcv09: Add error test for MSG_COPY flag | +0 | 1 reply | |
| 3/3 | syscalls/msgrcv09: Add error test for MSG_COPY flag | +0 | 5 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [LTP] [PATCH v1 0/3] increase msgrcv coverage
Hi!
Quoted 6 lines
1. The first patch add check for
msg_lrpidandmsg_rtime.
2. The second patch tests different msgtyp.
3. The third patch testsMSG_COPYflag(basic error test),not functional test because kernel selftest[1] has tested this.
Looking at the code there it actually does not seem to be automated test, so I think that we should include a test for MSG_COPY in LTP.
We can put a simple one into msgrcv07 we would call msgrcv() with MSG_COPY if we got an EINVAL we will skip the test since MSG_COPY is not supported.
Otherwise msgrcv with id 0 and 1 should retrieve our two messages, so we would check that the data are correct, then we would check that there are still two messages queue in the queue, we can do that with msgctl() and/or read them with regular msgrcv.
Signature · 2 lines
Cyril Hrubis [email protected]