Introduce sendpage_ok() to detect misused sendpage in network related drivers
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v10 Latest7 patches 3 repliesIn review
- v97 patches 5 repliesSuperseded
- v87 patches 5 repliesSuperseded
Earlier versions · 6
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v7 | 6 patches | 6 replies | Superseded | |
| v6 | 6 patches | 0 replies | Superseded | |
| v5 posting 2/2 | 3 patches | 4 replies | Superseded | |
| v5 posting 1/2 | 3 patches | 2 replies | Superseded | |
| v4 | 2 of 3 patches | 0 replies | Superseded | |
| v1 | 3 patches | 0 replies | Superseded |
Changelog from the cover letter
v10, fix WARN_ONCE() usage, and add Reivewed-by tag from Lee Duncan. v9, fix a typo pointed out by Greg KH.
add Acked-by tags from Martin K. Petersen and Ilya Dryomov.
v8: add WARN_ONCE() in kernel_sendpage() as Christoph suggested.
v7: remove outer brackets from the return line of sendpage_ok() as
Eric Dumazet suggested.
v6: fix page check in do_tcp_sendpages(), as Eric Dumazet suggested.
replace other open coded checks with sendpage_ok() in libceph, iscsi drivers.
v5, include linux/mm.h in include/linux/net.h
v4, change sendpage_ok() as an inline helper, and post it as
separate patch, as Christoph Hellwig suggested.
v3, introduce a more common sendpage_ok() as Sagi Grimberg suggested. v2, fix typo in patch subject
v1, the initial version.
Patches in v10 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | net: introduce helper sendpage_ok() in include/linux/net.hinclude/ | +16 | 0 replies | |
| 2/7 | net: add WARN_ONCE in kernel_sendpage() for improper zero-copy sendnet/ | +4 | 0 replies | |
| 3/7 | nvme-tcp: check page by sendpage_ok() before calling kernel_sendpage()drivers/ | +3 | 0 replies | |
| 4/7 | tcp: use sendpage_ok() to detect misused .sendpagenet/ | +2 | 0 replies | |
| 5/7 | drbd: code cleanup by using sendpage_ok() to check page for kernel_sendpage()drivers/ | +1 | 0 replies | |
| 6/7 | scsi: libiscsi: use sendpage_ok() in iscsi_tcp_segment_map()drivers/ | +1 | 0 replies | |
| 7/7 | libceph: use sendpage_ok() in ceph_tcp_sendpage()net/ | +1 | 0 replies |
Reviews trailers per patch
2 of 7 patches have a Reviewed-by or Acked-by.
| Patch | Lee Duncan | Martin K. Petersen | Jeff Layton |
|---|---|---|---|
| 1/7 | |||
| 2/7 | |||
| 3/7 | |||
| 4/7 | |||
| 5/7 | |||
| 6/7 | R-b | A-b | |
| 7/7 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v10 0/7] Introduce sendpage_ok() to detect misused sendpage in network related drivers
As Sagi Grimberg suggested, the original fix is refind to a more common inline routine:
static inline bool sendpage_ok(struct page *page)
{
return (!PageSlab(page) && page_count(page) >= 1);
}If sendpage_ok() returns true, the checking page can be handled by the concrete zero-copy sendpage method in network layer.
The v10 series has 7 patches, fixes a WARN_ONCE() usage from v9 series,
- The 1st patch in this series introduces sendpage_ok() in header file include/linux/net.h.
- The 2nd patch adds WARN_ONCE() for improper zero-copy send in kernel_sendpage().
- The 3rd patch fixes the page checking issue in nvme-over-tcp driver.
- The 4th patch adds page_count check by using sendpage_ok() in do_tcp_sendpages() as Eric Dumazet suggested.
- The 5th and 6th patches just replace existing open coded checks with the inline sendpage_ok() routine.
Coly Li
---
Changelog:
v10, fix WARN_ONCE() usage, and add Reivewed-by tag from Lee Duncan. v9, fix a typo pointed out by Greg KH.
add Acked-by tags from Martin K. Petersen and Ilya Dryomov.
v8: add WARN_ONCE() in kernel_sendpage() as Christoph suggested.
v7: remove outer brackets from the return line of sendpage_ok() as
Eric Dumazet suggested.
v6: fix page check in do_tcp_sendpages(), as Eric Dumazet suggested.
replace other open coded checks with sendpage_ok() in libceph, iscsi drivers.
v5, include linux/mm.h in include/linux/net.h
v4, change sendpage_ok() as an inline helper, and post it as
separate patch, as Christoph Hellwig suggested.
v3, introduce a more common sendpage_ok() as Sagi Grimberg suggested. v2, fix typo in patch subject
v1, the initial version.
Coly Li (7):
net: introduce helper sendpage_ok() in include/linux/net.h
net: add WARN_ONCE in kernel_sendpage() for improper zero-copy send
nvme-tcp: check page by sendpage_ok() before calling kernel_sendpage()
tcp: use sendpage_ok() to detect misused .sendpage
drbd: code cleanup by using sendpage_ok() to check page for
kernel_sendpage()
scsi: libiscsi: use sendpage_ok() in iscsi_tcp_segment_map()
libceph: use sendpage_ok() in ceph_tcp_sendpage()
drivers/block/drbd/drbd_main.c | 2 +- drivers/nvme/host/tcp.c | 7 +++---- drivers/scsi/libiscsi_tcp.c | 2 +- include/linux/net.h | 16 ++++++++++++++++ net/ceph/messenger.c | 2 +- net/ipv4/tcp.c | 3 ++- net/socket.c | 6 ++++-- 7 files changed, 28 insertions(+), 10 deletions(-)
Signature · 1 line
2.26.2