Skip to content

x86: switch default MSR behavior

Roger Pau Monne xen-devel 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest5 patches 3 repliesIn review
  2. v38 patches 19 repliesSuperseded
  3. v28 patches 17 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v18 patches12 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5x86/svm: handle BU_CFG and BU_CFG2 with casesxen/arch/x86/hvm/svm/svm.c+30 -131 reply
2/5x86/pv: allow reading FEATURE_CONTROL MSRxen/arch/x86/hvm/vmx/vmx.c xen/arch/x86/msr.c+13 -72 replies
3/5x86/pv: disallow access to unknown MSRsxen/arch/x86/pv/emul-priv-op.c+10 -80 replies
4/5x86/hvm: Disallow access to unknown MSRsxen/arch/x86/hvm/svm/svm.c xen/arch/x86/hvm/vmx/vmx.c+8 -180 replies
5/5x86/msr: Drop compatibility #GP handling in guest_{rd, wr}msr()xen/arch/x86/msr.c+0 -460 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchAndrew CooperJan BeulichKevin TianRoger Pau Monné
1/5R-b
2/5R-b R-b
3/5A-b
4/5R-b R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v4 thread

Cover letter [PATCH v4 0/5] x86: switch default MSR behavior

Hello,

The current series attempts to change the current MSR default handling behavior, which is to silently drop writes to writable MSRs, and allow reading any MSR not explicitly handled.

After this series access to MSRs not explicitly handled will trigger a #GP fault. I've tested this series with osstest and it doesn't introduce any regression, at least on the boxes selected for testing:

http://logs.test-lab.xenproject.org/osstest/logs/153697/

Thanks, Roger.

Andrew Cooper (2):
x86/hvm: Disallow access to unknown MSRs
x86/msr: Drop compatibility #GP handling in guest_{rd,wr}msr()

Roger Pau Monne (3):
x86/svm: handle BU_CFG and BU_CFG2 with cases
x86/pv: allow reading FEATURE_CONTROL MSR
x86/pv: disallow access to unknown MSRs

 xen/arch/x86/hvm/svm/svm.c     | 53 ++++++++++++++++++++------------
 xen/arch/x86/hvm/vmx/vmx.c     | 24 +++------------
 xen/arch/x86/msr.c             | 56 +++++++---------------------------
 xen/arch/x86/pv/emul-priv-op.c | 18 ++++++-----
 4 files changed, 60 insertions(+), 91 deletions(-)
Signature · 1 line
2.28.0