Skip to content

blk-mq: implement queue quiesce via percpu_ref for BLK_MQ_F_BLOCKING

Ming Lei linux-block linux-nvme 8 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v8 Latest4 patches 2 repliesIn review
  2. v74 patches 0 repliesSuperseded
  3. v64 patches 3 repliesSuperseded
Earlier versions · 5
VersionPostedPatchesRepliesStatus
v54 patches10 repliesSuperseded
v44 patches5 repliesSuperseded
v34 patches11 repliesSuperseded
v22 patches12 repliesSuperseded
v11 patch14 repliesSuperseded

Changes in v8 from the cover letter

- rebase on latest linus tree, only there is small fuzz change on 2/4

Patches in v8 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4block: use test_and_{clear|test}_bit to set/clear QUEUE_FLAG_QUIESCEDblock/blk-core.c block/blk-mq.c block/blk.h+23 -30 replies
2/4blk-mq: implement queue quiesce via percpu_ref for BLK_MQ_F_BLOCKINGblock/blk-mq-sysfs.c block/blk-mq.c block/blk-sysfs.c +2 more+79 -690 replies
3/4blk-mq: add tagset quiesce interfaceblock/blk-mq.c include/linux/blk-mq.h+51 -100 replies
4/4nvme: use blk_mq_[un]quiesce_tagsetdrivers/nvme/host/core.c+9 -100 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchHannes ReineckeSagi GrimbergKeith Busch
1/4R-b T-b R-b
2/4R-b T-b R-b
3/4R-b T-b R-b
4/4R-b T-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v8 thread

Cover letter [PATCH V8 0/4] blk-mq: implement queue quiesce via percpu_ref for BLK_MQ_F_BLOCKING

Hi Jens,

The 1st patch add .mq_quiesce_mutex for serializing quiesce/unquiesce, and prepares for replacing srcu with percpu_ref.

The 2nd patch replaces srcu with percpu_ref.

The 3rd patch adds tagset quiesce interface.

The 4th patch applies tagset quiesce interface for NVMe subsystem.

V8:
- rebase on latest linus tree, only there is small fuzz change on 2/4

V7:
- base on latest for-5.10/block, only there is small change on 2/4

V6:
- base on for-5.10/block directly, instead of being against on patchset of 'percpu_ref & block: reduce memory footprint of percpu_ref in fast path', because these patches don't depend on that patchset.

V5:
- warn once in case that driver unquiesces its queue being quiesce and not done, only patch 2 is modified

V4:
- remove .mq_quiesce_mutex, and switch to test_and_[set|clear] for avoiding duplicated quiesce action
- pass blktests(block, nvme)

V3:
- add tagset quiesce interface
- apply tagset quiesce interface for NVMe
- pass blktests(block, nvme)

V2:
- add .mq_quiesce_lock
- add comment on patch 2 wrt. handling hctx_lock() failure
- trivial patch style change

Ming Lei (3):
block: use test_and_{clear|test}_bit to set/clear QUEUE_FLAG_QUIESCED
blk-mq: implement queue quiesce via percpu_ref for BLK_MQ_F_BLOCKING
blk-mq: add tagset quiesce interface

Sagi Grimberg (1):
nvme: use blk_mq_[un]quiesce_tagset

 block/blk-core.c         |  13 +++
 block/blk-mq-sysfs.c     |   2 -
 block/blk-mq.c           | 182 +++++++++++++++++++++++++--------------
 block/blk-sysfs.c        |   6 +-
 block/blk.h              |   2 +
 drivers/nvme/host/core.c |  19 ++--
 include/linux/blk-mq.h   |  10 +--
 include/linux/blkdev.h   |   4 +
 8 files changed, 154 insertions(+), 84 deletions(-)
Cc Hannes Reinecke <[email protected]>
Cc Sagi Grimberg <[email protected]>
Cc Bart Van Assche <[email protected]>
Cc Johannes Thumshirn <[email protected]>
Cc Chao Leng <[email protected]>
Signature · 1 line
2.25.2