Skip to content

input: misc: Add IBM Operation Panel driver

Eddie James linux-aspeed linux-devicetree linux-i2c linux-input lkml 3 versions – Applied

Status from this message: Applied to the aspeed tree for v5.10.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 8 repliesApplied
  2. v25 patches 3 repliesSuperseded
  3. v15 patches 13 repliesSuperseded

Changes in v3 from the cover letter

- Add "additionalProperties: false" to dts doc
- Refactor switch statement in the input driver; check command size and call the processing function within the STOP case
- Use a different definition name for Aspeed interrupt status mask

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/5dt-bindings: input: Add documentation for IBM Operation PanelDocumentation/devicetree/bindings/input/ibm,op-panel.yaml MAINTAINERS+47 -00 replies
2/5input: misc: Add IBM Operation Panel driverMAINTAINERS drivers/input/misc/Kconfig drivers/input/misc/Makefile +1 more+209 -02 replies
3/5i2c: aspeed: Mask IRQ status to relevant bitsdrivers/i2c/busses/i2c-aspeed.c+2 -04 replies
4/5ARM: dts: Aspeed: Tacoma: Add IBM Operation Panel I2C devicearch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts+7 -01 reply
5/5ARM: dts: Aspeed: Rainier: Add IBM Operation Panel I2C devicearch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts+7 -01 reply

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchRob HerringJoel StanleyTao RenWolfram Sang
1/5R-b A-b
2/5R-b R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v3 thread

Cover letter [PATCH v3 0/5] input: misc: Add IBM Operation Panel driver

This series adds support for input from the IBM Operation Panel, which is a simple controller with three buttons and an LCD display meant for interacting with a server. It's connected over I2C, typically to a service processor. This series only supports the input from the panel, in which the panel masters the I2C bus and sends data to the host system when someone presses a button on the controller.

Changes since v2:
- Add "additionalProperties: false" to dts doc
- Refactor switch statement in the input driver; check command size and call the processing function within the STOP case
- Use a different definition name for Aspeed interrupt status mask

Changes since v1:
- Redo DTS documentation example to use I2C_OWN_SLAVE_ADDRESS
- Reject commands received in the input driver that are too long
- Add a definition for the interrupt status mask in the Aspeed I2C driver
- Use I2C_OWN_SLAVE_ADDRESS for both dts additions

Eddie James (5):
dt-bindings: input: Add documentation for IBM Operation Panel
input: misc: Add IBM Operation Panel driver
i2c: aspeed: Mask IRQ status to relevant bits
ARM: dts: Aspeed: Tacoma: Add IBM Operation Panel I2C device
ARM: dts: Aspeed: Rainier: Add IBM Operation Panel I2C device

 .../bindings/input/ibm,op-panel.yaml          |  41 ++++
 MAINTAINERS                                   |   7 +
 arch/arm/boot/dts/aspeed-bmc-ibm-rainier.dts  |   7 +
 arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts   |   7 +
 drivers/i2c/busses/i2c-aspeed.c               |   2 +
 drivers/input/misc/Kconfig                    |  18 ++
 drivers/input/misc/Makefile                   |   1 +
 drivers/input/misc/ibm-panel.c                | 189 ++++++++++++++++++
 8 files changed, 272 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/input/ibm,op-panel.yaml
 create mode 100644 drivers/input/misc/ibm-panel.c
Signature · 1 line
2.26.2