Skip to content

simplify unit-testing of rawdevs

Bruce Richardson dpdk-dev 2 versions – Applied

Status from this message: Applied, thanks

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 4 repliesApplied
  2. v14 patches 0 repliesSuperseded

Changes in v2 from the cover letter

- dropped patch 2, which had ioat-only changes to debug prints, and wasn't relevant to the rest of the set
- improved the naming of the test functions in test_rawdev.c
- added release note entry for these changes

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/3raw/ioat: support multiple devices being testeddrivers/raw/ioat/ioat_rawdev_test.c+13 -41 reply
2/3app/test: change rawdev autotest to run selftest on all devsapp/test/test_rawdev.c doc/guides/rel_notes/release_20_11.rst+37 -21 reply
3/3app/test: remove ioat-specific autotestapp/test/test_rawdev.c doc/guides/rel_notes/release_20_11.rst+2 -201 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchKevin Laatz
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [dpdk-dev] [PATCH v2 0/3] simplify unit-testing of rawdevs

At present the "rawdev_autotest" command creates a skeleton rawdev and runs a series of tests on the rawdev API and on that rawdev. While the rawdev API set includes a "selftest" function, it is not hooked up to this test so to test an individual rawdev driver, e.g. ioat, requires that a new test command be added.

This patchset improves the situation by changing the UT to first run the existing API tests, but then call selftest on all rawdevs on the system. This removes the need for any new test commands for new drivers. If there are multiple rawdevs on a system, the sub-set to be tested can be limited via existing means such as using the device block/allow EAL parameters or similarly via vdev args, etc.

As part of this change, the ioat rawdev autotest is fixed to allow calling on multiple instances inside the one test run, and thereafter the custom test command for it is removed as it is no longer necessary.

Depends-on: series-12105 ("Enhance rawdev APIs")

V2:
- dropped patch 2, which had ioat-only changes to debug prints, and wasn't relevant to the rest of the set
- improved the naming of the test functions in test_rawdev.c
- added release note entry for these changes

Bruce Richardson (3):
raw/ioat: support multiple devices being tested app/test: change rawdev autotest to run selftest on all devs app/test: remove ioat-specific autotest

 app/test/test_rawdev.c                 | 34 +++++++++++++++++---------
 doc/guides/rel_notes/release_20_11.rst |  7 ++++++
 drivers/raw/ioat/ioat_rawdev_test.c    | 17 ++++++++++---
 3 files changed, 42 insertions(+), 16 deletions(-)
Signature · 1 line
2.25.1