Skip to content

irqchip/gic: Generalize use of HW-based retriggering

Marc Zyngier linux-arm-kernel lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 3 repliesIn review
  2. v19 patches 4 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4genirq: Walk the irq_data hierarchy when resending an interruptkernel/irq/resend.c+13 -23 replies
2/4irqchip/gic-v2, v3: Implement irq_chip->irq_retrigger()drivers/irqchip/irq-gic-v3.c drivers/irqchip/irq-gic.c+13 -00 replies
3/4irqchip/git-v3-its: Implement irq_retrigger callback for device-triggered LPIsdrivers/irqchip/irq-gic-v3-its.c+6 -00 replies
4/4irqchip/gic-v2, v3: Prevent SW resends entirelydrivers/irqchip/irq-gic-v3.c drivers/irqchip/irq-gic.c+9 -20 replies

Reviews trailers per patch

1 of 4 patches has a Reviewed-by or Acked-by.

PatchValentin Schneider
1/4R-b
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/4] irqchip/gic: Generalize use of HW-based retriggering

Valentin recently pointed out that that relying on SW-based retrigger with any of the GIC interrupt controllers is both inefficient and slightly broken, as it messes the GIC's own state machine.

For this to work with the hierarchical irqchip model that the GIC uses, we need check_irq_resend grow an understanding of hierarchies, something it has been lacking for some time.

The 3 other patches simply implement the HW resend callbacks, and finally prevent any SW resend for the GICs.

Unless anyone objects, I plan to take this into 5.10.

* From v1:
- Dropped most of the patches in favour of a teaching the core kernel to use irq_chip_retriger_hierarchy()

Marc Zyngier (2):
genirq: Walk the irq_data hierarchy when resending an interrupt irqchip/git-v3-its: Implement irq_retrigger callback for
device-triggered LPIs

Valentin Schneider (2):
irqchip/gic-v2, v3: Implement irq_chip->irq_retrigger() irqchip/gic-v2, v3: Prevent SW resends entirely

 drivers/irqchip/irq-gic-v3-its.c |  6 ++++++
 drivers/irqchip/irq-gic-v3.c     | 12 +++++++++++-
 drivers/irqchip/irq-gic.c        | 12 +++++++++++-
 kernel/irq/resend.c              | 15 +++++++++++++--
 4 files changed, 41 insertions(+), 4 deletions(-)
Signature · 1 line
2.28.0