Skip to content

nbd: build qemu-nbd on Windows

Daniel P. Berrangé qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 5 repliesIn review
  2. v12 patches 5 repliesSuperseded

Changes in v2 from the cover letter

- Split second patch into two parts
- Use HAVE_NBD_DEVICE condition to disable SIGTERM handler not WIN32

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3block: add missing socket_init() calls to toolsqemu-img.c qemu-io.c qemu-nbd.c+5 -00 replies
2/3nbd: skip SIGTERM handler if NBD device support is not builtqemu-nbd.c+4 -11 reply
3/3nbd: disable signals and forking on Windows buildsmeson.build qemu-nbd.c+7 -54 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchEric Blake
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] nbd: build qemu-nbd on Windows

We are already building the NBD client and server on Windows when it is used via the main system emulator binaries. This demonstrates there is no fundamental blocker to buildig the qemu-nbd binary too.

Changed in v2:

- Split second patch into two parts
- Use HAVE_NBD_DEVICE condition to disable SIGTERM handler not WIN32

Daniel P. Berrangé (3):
block: add missing socket_init() calls to tools
nbd: skip SIGTERM handler if NBD device support is not built
nbd: disable signals and forking on Windows builds

 meson.build |  7 ++-----
 qemu-img.c  |  2 ++
 qemu-io.c   |  2 ++
 qemu-nbd.c  | 11 ++++++++++-
 4 files changed, 16 insertions(+), 6 deletions(-)
Signature · 1 line
2.26.2