Skip to content

spapr NVDIMM: consider 'nvdimm' machine option

Daniel Henrique Barboza qemu-devel 1 version Applied

Status from this message: Applied to ppc-for-5.2, thanks.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 1 replyApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/3ppc/spapr_nvdimm: use g_autofree in spapr_nvdimm_validate_opts()hw/ppc/spapr_nvdimm.c+1 -20 replies
2/3spapr, spapr_nvdimm: fold NVDIMM validation in the same placehw/ppc/spapr.c hw/ppc/spapr_nvdimm.c include/hw/ppc/spapr_nvdimm.h+16 -160 replies
3/3ppc/spapr_nvdimm: do not enable support with 'nvdimm=off'hw/ppc/spapr_nvdimm.c+18 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] spapr NVDIMM: consider 'nvdimm' machine option

This series aims to solve bug [1].

First patch is a trivial cleanup, feel free to squash into patch 02. Patch 02 attempts a code simplification to put all NVDIMM related logic in the same function.

Patch 03 is where the actual fix is implemented. My initial approach here was to make the handling of '-machine nvdimm' for pSeries similar to how it is handled elsewhere, but I wasn't able to accomplish that without either (1) breaking up existing pseries-5.1 guests that didn't care about this option or (2) make pseries-5.1 and pseries-5.2+ machines to have different semantics for it.

I ended up doing what I was sure was sensible: if the user puts '-machine nvdimm=off', we must comply to that.

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1848887

Daniel Henrique Barboza (3):
ppc/spapr_nvdimm: use g_autofree in spapr_nvdimm_validate_opts() spapr, spapr_nvdimm: fold NVDIMM validation in the same place ppc/spapr_nvdimm: do not enable support with 'nvdimm=off'

 hw/ppc/spapr.c                | 18 ++++++------------
 hw/ppc/spapr_nvdimm.c         | 31 +++++++++++++++++++++++++++----
 include/hw/ppc/spapr_nvdimm.h |  4 ++--
 3 files changed, 35 insertions(+), 18 deletions(-)
Signature · 1 line
2.26.2