Skip to content

avoid running "git-subcmd" in the dashed form

Junio C Hamano git 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 11 repliesIn review
  2. v13 patches 20 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2transport-helper: do not run git-remote-ext etc. in dashed formtransport-helper.c+2 -20 replies
2/2cvsexportcommit: do not run git programs in dashed formgit-cvsexportcommit.perl+8 -818 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchEric Sunshine
1/2
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] avoid running "git-subcmd" in the dashed form
Quoted 5 lines · Junio C Hamano

I think the cvsexportcommit and transport-helper changes are worth salvaging even if we don't remove builtin binaries, so I'll split them and whip them a bit more into a reasonable shape to be merged to 'next'. The "break those who say 'git-cat-file'" can be left for future.

And here it is.

These two patches are clean-ups that are worth doing whether we decide to remove on-disk binaries for the builtin commands.

I droped the third one, that actually stops users from running built-in commands using the dashed form, at least for now. It can be resurrected later if we really wants to propose removal to the users, but I am not inclined to make such a proposal right now.

Junio C Hamano (2):
transport-helper: do not run git-remote-ext etc. in dashed form
cvsexportcommit: do not run git programs in dashed form

 git-cvsexportcommit.perl | 16 ++++++++--------
 transport-helper.c       |  4 ++--
 2 files changed, 10 insertions(+), 10 deletions(-)
Signature · 1 line
2.28.0-454-g5f859b1948