Skip to content

multipath-tools: valgrind tests & fixes

[email protected] dm-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest10 patches 1 replyIn review

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10multipath-tools: Makefile.inc: fix compilation with gcc 4.xMakefile.inc+1 -10 replies
2/10multipath-tools: Makefile: add "valgrind-test" targetMakefile tests/Makefile tests/README.md+22 -20 replies
3/10multipath-tools tests: fix memory leak in alias testtests/alias.c+2 -00 replies
4/10multipath-tools tests: fix memory leak in hwtable testtests/hwtable.c+4 -00 replies
5/10multipath-tools tests: fix memory leak in vpd testtests/vpd.c+8 -100 replies
6/10libmultipath: fix memory leak in ble handlerslibmultipath/dict.c+9 -30 replies
7/10libmultipath: fix enable_foreign memory leaklibmultipath/config.c multipath/main.c+3 -10 replies
8/10libmultipath: fix invalid memory access in is_token()libmultipath/parser.c+3 -10 replies
9/10libmultipath: alloc_strvec: NULL-initialize strvec elementslibmultipath/parser.c+1 -00 replies
10/10libmultipath: validate_config_strvec(): avoid out-of-bounds accesslibmultipath/parser.c+7 -50 replies

Reviews trailers per patch

None of the 10 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchBenjamin Marzinski
SeriesR-b
1/10
2/10
3/10
4/10
5/10
6/10
7/10
8/10
9/10
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/10] multipath-tools: valgrind tests & fixes

From: Martin Wilck <[email protected]>

Hi Christophe and Ben,

this series adds a make target to run unit tests under valgrind, and fixes the issues I found using this test target.

It contains the patches I sent yesterday ([PATCH 1/5] multipath-tools tests:
fix memory leak in alias test), but in a different order / numbering, which seems more appropriate now.

Regards,
Martin

Martin Wilck (10):
multipath-tools: Makefile.inc: fix compilation with gcc 4.x
multipath-tools: Makefile: add "valgrind-test" target multipath-tools tests: fix memory leak in alias test multipath-tools tests: fix memory leak in hwtable test multipath-tools tests: fix memory leak in vpd test
libmultipath: fix memory leak in ble handlers
libmultipath: fix enable_foreign memory leak
libmultipath: fix invalid memory access in is_token()
libmultipath: alloc_strvec: NULL-initialize strvec elements
libmultipath: validate_config_strvec(): avoid out-of-bounds access

 Makefile              |  3 +++
 Makefile.inc          |  2 +-
 libmultipath/config.c |  2 ++
 libmultipath/dict.c   | 12 +++++++++---
 libmultipath/parser.c | 17 +++++++++++------
 multipath/main.c      |  2 +-
 tests/Makefile        | 13 +++++++++++--
 tests/README.md       |  8 ++++++++
 tests/alias.c         |  2 ++
 tests/hwtable.c       |  4 ++++
 tests/vpd.c           | 18 ++++++++----------
 11 files changed, 60 insertions(+), 23 deletions(-)
Signature · 1 line
2.28.0