Skip to content

fix up generic dmlogwrites tests to work with XFS

Brian Foster fstests linux-xfs 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 3 repliesIn review
  2. v14 patches 14 repliesSuperseded

Changes in v3 from the cover letter

- Re-add dm-thinp changes.
- Drop discard checks (from v1) and XFS disablement (from v2).
- Use _require_scratch_nocheck in generic/470 to avoid spurious repair noise now that the test no longer runs mkfs on the scratch dev.
v2: https://lore.kernel.org/fstests/[email protected]/
- Drop all dmthinp changes. Unconditionally disable tests on XFS.
v1: https://lore.kernel.org/fstests/[email protected]/

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3generic/455: use thin volume for dmlogwrites target devicetests/generic/455+22 -141 reply
2/3generic/457: use thin volume for dmlogwrites target devicetests/generic/457+21 -121 reply
3/3generic/470: use thin volume for dmlogwrites target devicetests/generic/470+17 -61 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchAmir Goldstein
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/3] fix up generic dmlogwrites tests to work with XFS

Hi all,

This version removes the discard zeroing check as Christoph points out that discard behavior is generally not predictable. The remaining generic dm-logwrites tests are still updated to use dm-thinp such that discards from the recovery tool clear block ranges reasonably reliably. This allows the tests to function correctly on filesystems like XFS while a more generic solution is investigated.

Brian

v3:
- Re-add dm-thinp changes.
- Drop discard checks (from v1) and XFS disablement (from v2).
- Use _require_scratch_nocheck in generic/470 to avoid spurious repair noise now that the test no longer runs mkfs on the scratch dev.
v2: https://lore.kernel.org/fstests/[email protected]/
- Drop all dmthinp changes. Unconditionally disable tests on XFS.
v1: https://lore.kernel.org/fstests/[email protected]/

Brian Foster (3):
generic/455: use thin volume for dmlogwrites target device generic/457: use thin volume for dmlogwrites target device generic/470: use thin volume for dmlogwrites target device

 tests/generic/455 | 36 ++++++++++++++++++++++--------------
 tests/generic/457 | 33 +++++++++++++++++++++------------
 tests/generic/470 | 23 +++++++++++++++++------
 3 files changed, 60 insertions(+), 32 deletions(-)
Signature · 1 line
2.25.4