Skip to content

soundwire: use FIELD_{GET|PREP} in subsystem

Vinod Koul alsa-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest9 patches 2 repliesIn review
  2. v19 patches 6 repliesSuperseded

Changes in v2 from the cover letter

- fold in fixes provided by Bard and Pierre
- Use GENMAS_ULL for addr
- rebase to next and fold in new intel change

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9soundwire: define and use addr bit masksinclude/linux/soundwire/sdw.h+14 -70 replies
2/9soundwire: bus: use FIELD_GET()drivers/soundwire/bus.c+3 -30 replies
3/9soundwire: slave: use SDW_DISCO_LINK_ID()drivers/soundwire/slave.c+1 -10 replies
4/9soundwire: stream: use FIELD_{GET|PREP}drivers/soundwire/stream.c+5 -80 replies
5/9soundwire: qcom : use FIELD_{GET|PREP}drivers/soundwire/qcom.c+7 -150 replies
6/9soundwire: cadence: use FIELD_{GET|PREP}drivers/soundwire/cadence_master.c+26 -350 replies
7/9soundwire: intel: use FIELD_{GET|PREP}drivers/soundwire/intel.c+18 -340 replies
8/9soundwire: intel_init: use FIELD_{GET|PREP}drivers/soundwire/intel_init.c+1 -10 replies
9/9soundwire: remove SDW_REG_SHIFT()include/linux/soundwire/sdw_registers.h+0 -70 replies

Reviews trailers per patch

None of the 9 patches has a Reviewed-by or Acked-by.

PatchBard Liao
SeriesT-b
1/9
2/9
3/9
4/9
5/9
6/9
7/9
8/9
9/9

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/9] soundwire: use FIELD_{GET|PREP} in subsystem

Use the FIELD_{GET|PREP} in soundwire subsytem and remove the local SDW_REG_SHIFT(). This makes code IMO look much neater

Tested this on db845c board

Changes in v2:
- fold in fixes provided by Bard and Pierre
- Use GENMAS_ULL for addr
- rebase to next and fold in new intel change

Vinod Koul (9):
soundwire: define and use addr bit masks
soundwire: bus: use FIELD_GET()
soundwire: slave: use SDW_DISCO_LINK_ID()
soundwire: stream: use FIELD_{GET|PREP}
soundwire: qcom : use FIELD_{GET|PREP}
soundwire: cadence: use FIELD_{GET|PREP}
soundwire: intel: use FIELD_{GET|PREP}
soundwire: intel_init: use FIELD_{GET|PREP}
soundwire: remove SDW_REG_SHIFT()

 drivers/soundwire/bus.c                 |  6 +--
 drivers/soundwire/cadence_master.c      | 61 +++++++++++--------------
 drivers/soundwire/intel.c               | 52 ++++++++-------------
 drivers/soundwire/intel_init.c          |  2 +-
 drivers/soundwire/qcom.c                | 22 +++------
 drivers/soundwire/slave.c               |  2 +-
 drivers/soundwire/stream.c              | 13 ++----
 include/linux/soundwire/sdw.h           | 21 ++++++---
 include/linux/soundwire/sdw_registers.h |  7 ---
 9 files changed, 75 insertions(+), 111 deletions(-)
Signature · 1 line
2.26.2