Skip to content

crypto: fix build with gcrypt

Daniel P. Berrangé qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 3 repliesIn review
  2. v12 patches 5 repliesSuperseded

Changes in v2 from the cover letter

- Change way we add library dependencies in meson rules to fix linux-user build with gcrypt/gnutls too.
- Extend CI coverage to test 1 system and 1 linux-user build with each crypto combination, not merely tools.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2crypto: fix build with gcrypt enabledconfigure crypto/meson.build meson.build+38 -111 reply
2/2gitlab: expand test coverage for crypto builds.gitlab-ci.yml tests/docker/dockerfiles/centos7.docker tests/docker/dockerfiles/centos8.docker+72 -02 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchAlex BennéePhilippe Mathieu-Daudé
1/2R-b T-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] crypto: fix build with gcrypt

The build system failed to add gcrypt flags and also didn't link to gnutls in all scenarios. This was missed because of the lack of CI coverage for various build scenarios

Changed in v2:

- Change way we add library dependencies in meson rules to fix linux-user build with gcrypt/gnutls too.
- Extend CI coverage to test 1 system and 1 linux-user build with each crypto combination, not merely tools.

Daniel P. Berrangé (2):
crypto: fix build with gcrypt enabled
gitlab: expand test coverage for crypto builds

 .gitlab-ci.yml                          | 69 +++++++++++++++++++++++++
 configure                               |  2 +
 crypto/meson.build                      | 42 +++++++++++----
 meson.build                             |  5 ++
 tests/docker/dockerfiles/centos7.docker |  2 +
 tests/docker/dockerfiles/centos8.docker |  1 +
 6 files changed, 110 insertions(+), 11 deletions(-)
Signature · 1 line
2.26.2