Skip to content

ia64: clean-up header dependency and build process, fix build warning

Masahiro Yamada linux-efi linux-ia64 linux-kbuild lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3ia64: do not typedef struct pal_min_state_area_sarch/ia64/include/asm/mca.h arch/ia64/include/asm/pal.h arch/ia64/include/asm/sal.h +3 more+16 -161 reply
2/3ia64: remove unneeded header includes from <asm/mca.h>arch/ia64/include/asm/mca.h arch/ia64/kernel/efi.c arch/ia64/kernel/mca.c+5 -62 replies
3/3ia64: remove generated/nr-irqs.h generation to fix build warningarch/ia64/Makefile arch/ia64/include/asm/irq.h arch/ia64/kernel/Makefile +1 more+3 -342 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchRandy DunlapArd Biesheuvel
1/3R-b
2/3R-b A-b
3/3R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] ia64: clean-up header dependency and build process, fix build warning

Randy Dunlap reports the following warning with CONFIG_IA64_PALINFO=m:

../scripts/Makefile.build:68: 'arch/ia64/kernel/palinfo.ko' will not be built even though obj-m is specified. ../scripts/Makefile.build:69: You cannot use subdir-y/m to visit a module Makefile. Use obj-y/m instead.

This comes from the fact Kbuild descends into arch/ia64/kernel/ twice.

First, to generate <generated/nr-irqs.h>,
Second, to build kernel and module objects.

The warning is emitted in the first descend because it is not the intended usage.

I looked into the code closely, and noticed arch/ia64/kernel/nr-irqs.c was not needed in the first place.

It was separated out of arch/ia64/kernel/asm-offsets.c just because <asm/mca.h> was including too many bogus headers.

IA64 is not actively maintained, and there exists unneeded obsolete code.

The first two patches are the outcome when I played with ARCH=ia64 builds, but not prerequisites for 3/3. Anyway I believe they are nice cleanups and folded in this patch set.

3/3 is the important one to fix the false positive warning, and it is a nice cleanup too.

Masahiro Yamada (3):
ia64: do not typedef struct pal_min_state_area_s
ia64: remove unneeded header includes from <asm/mca.h>
ia64: remove generated/nr-irqs.h generation to fix build warning

 arch/ia64/Makefile             |  6 ------
 arch/ia64/include/asm/irq.h    |  4 +++-
 arch/ia64/include/asm/mca.h    | 11 ++++-------
 arch/ia64/include/asm/pal.h    |  4 ++--
 arch/ia64/include/asm/sal.h    |  2 +-
 arch/ia64/kernel/Makefile      |  5 -----
 arch/ia64/kernel/asm-offsets.c | 18 +++++++++---------
 arch/ia64/kernel/efi.c         |  1 +
 arch/ia64/kernel/mca.c         |  5 +++--
 arch/ia64/kernel/mca_drv.c     |  2 +-
 arch/ia64/kernel/nr-irqs.c     | 22 ----------------------
 11 files changed, 24 insertions(+), 56 deletions(-)
 delete mode 100644 arch/ia64/kernel/nr-irqs.c
Signature · 1 line
2.25.1