Skip to content

RFC Fix a deadlock in the SCSI power management code

Bart Van Assche linux-scsi 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest6 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6ide: Do not set the RQF_PREEMPT flag for sense requestsdrivers/ide/ide-atapi.c+0 -10 replies
2/6scsi: Remove an incorrect commentinclude/scsi/scsi_device.h+1 -10 replies
3/6scsi: Pass a request queue pointer to __scsi_execute()drivers/scsi/scsi_lib.c include/scsi/scsi_device.h+9 -110 replies
4/6scsi_transport_spi: Make spi_execute() accept a request queue pointerdrivers/scsi/scsi_transport_spi.c+36 -330 replies
5/6scsi_transport_spi: Freeze request queues instead of quiescingdrivers/scsi/scsi_lib.c drivers/scsi/scsi_priv.h drivers/scsi/scsi_transport_spi.c +1 more+51 -351 reply
6/6block, scsi, ide: Only submit power management requests in state RPM_SUSPENDEDblock/blk-core.c block/blk-mq-debugfs.c block/blk-mq.c +5 more+24 -293 replies

Reviews trailers per patch

None of the 6 patches has a Reviewed-by or Acked-by.

PatchMartin Kepplinger
SeriesT-b
1/6
2/6
3/6
4/6
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH RFC 0/6] Fix a deadlock in the SCSI power management code

Recently Martin Kepplinger reported a problem with the SCSI runtime PM code. Alan Stern root-caused the reported deadlock. This patch series is an attempt to fix that deadlock. These patches compile but have not yet been tested.

Bart Van Assche (6):
ide: Do not set the RQF_PREEMPT flag for sense requests
scsi: Remove an incorrect comment
scsi: Pass a request queue pointer to __scsi_execute()
scsi_transport_spi: Make spi_execute() accept a request queue pointer
scsi_transport_spi: Freeze request queues instead of quiescing block, scsi, ide: Only submit power management requests in state
RPM_SUSPENDED

 block/blk-core.c                  |   6 +-
 block/blk-mq-debugfs.c            |   1 -
 block/blk-mq.c                    |   4 +-
 drivers/ide/ide-atapi.c           |   1 -
 drivers/ide/ide-io.c              |   3 +-
 drivers/ide/ide-pm.c              |   2 +-
 drivers/scsi/scsi_lib.c           |  61 ++++++++-------
 drivers/scsi/scsi_priv.h          |   2 +
 drivers/scsi/scsi_transport_spi.c | 123 +++++++++++++++++-------------
 include/linux/blk-mq.h            |   4 +-
 include/linux/blkdev.h            |   6 +-
 include/scsi/scsi_device.h        |  16 ++--
 12 files changed, 120 insertions(+), 109 deletions(-)