Skip to content

Use implicit kref infra

Luben Tuikov amd-gfx dri-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 17 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3drm: No warn for drivers who provide releasedrivers/gpu/drm/drm_drv.c+2 -10 replies
2/3drm/amdgpu: Remove drmm final freedrivers/gpu/drm/amd/amdgpu/amdgpu_drv.c+0 -20 replies
3/3drm/amdgpu: Remove superfluous NULL checkdrivers/gpu/drm/amd/amdgpu/amdgpu_device.c+0 -32 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchDaniel Vetter
1/3
2/3
3/3A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] Use implicit kref infra

Use the implicit kref infrastructure to free the container struct amdgpu_device, container of struct drm_device.

First, in drm_dev_register(), do not indiscriminately warn when a DRM driver hasn't opted for managed.final_kfree, but instead check if the driver has provided its own "release" function callback in the DRM driver structure. If that is the case, no warning.

Remove drmm_add_final_kfree(). We take care of that, in the kref "release" callback when all refs are down to 0, via drm_dev_put(), i.e. the free is implicit.

Remove superfluous NULL check, since the DRM device to be suspended always exists, so long as the underlying PCI and DRM devices exist.

Luben Tuikov (3):
drm: No warn for drivers who provide release
drm/amdgpu: Remove drmm final free
drm/amdgpu: Remove superfluous NULL check

 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 ---
 drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c    | 2 --
 drivers/gpu/drm/drm_drv.c                  | 3 ++-
 3 files changed, 2 insertions(+), 6 deletions(-)
Signature · 6 lines
2.28.0.394.ge197136389

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx