Skip to content

Fix in-kernel active_speed type

Leon Romanovsky linux-rdma netdev 2 versions – Applied

Status from this message: Applied to for-next, thanks

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 4 repliesApplied
  2. v13 patches 7 repliesSuperseded

Changes in v2 from the cover letter

* Changed WARN_ON casting to be saturated value instead while returning active_speed to the user.
v1: https://lore.kernel.org/linux-rdma/[email protected]
* Changed patch #1 to fix memory corruption to help with bisect. No change in series, because the added code is changed anyway in patch #3.

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/3net/mlx5: Refactor query port speed functionsdrivers/infiniband/hw/mlx5/main.c drivers/net/ethernet/mellanox/mlx5/core/ipoib/ethtool.c drivers/net/ethernet/mellanox/mlx5/core/port.c +1 more+25 -550 replies
2/3RDMA/mlx5: Delete duplicated mlx5_ptys_width enumdrivers/infiniband/hw/mlx5/main.c drivers/net/ethernet/mellanox/mlx5/core/ipoib/ethtool.c include/linux/mlx5/port.h+14 -220 replies
3/3RDMA: Fix link active_speed sizedrivers/infiniband/core/uverbs_std_types_device.c drivers/infiniband/core/verbs.c drivers/infiniband/hw/bnxt_re/bnxt_re.h +7 more+15 -180 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchMichael Guralnik
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH rdma-next v2 0/3] Fix in-kernel active_speed type

From: Leon Romanovsky <[email protected]>

Changelog:
v2:
* Changed WARN_ON casting to be saturated value instead while returning active_speed to the user.
v1: https://lore.kernel.org/linux-rdma/[email protected]
* Changed patch #1 to fix memory corruption to help with bisect. No change in series, because the added code is changed anyway in patch #3.
v0:
* https://lore.kernel.org/linux-rdma/[email protected]

----------------------------------------------------------------------------------------

IBTA declares speed as 16 bits, but kernel stores it in u8. This series fixes in-kernel declaration while keeping external interface intact.

Thanks

Aharon Landau (3):
net/mlx5: Refactor query port speed functions RDMA/mlx5: Delete duplicated mlx5_ptys_width enum
RDMA: Fix link active_speed size

 .../infiniband/core/uverbs_std_types_device.c |  3 +-
 drivers/infiniband/core/verbs.c               |  2 +-
 drivers/infiniband/hw/bnxt_re/bnxt_re.h       |  2 +-
 drivers/infiniband/hw/hfi1/verbs.c            |  2 +-
 drivers/infiniband/hw/mlx5/main.c             | 41 +++++++------------
 drivers/infiniband/hw/ocrdma/ocrdma_verbs.c   |  2 +-
 drivers/infiniband/hw/qedr/verbs.c            |  2 +-
 drivers/infiniband/hw/qib/qib.h               |  6 +--
 .../infiniband/hw/vmw_pvrdma/pvrdma_verbs.h   |  2 +-
 .../mellanox/mlx5/core/ipoib/ethtool.c        | 31 ++------------
 .../net/ethernet/mellanox/mlx5/core/port.c    | 23 ++---------
 include/linux/mlx5/port.h                     | 15 +++++--
 include/rdma/ib_verbs.h                       |  4 +-
 13 files changed, 47 insertions(+), 88 deletions(-)

--
2.26.2