Skip to content

virtio-iommu-pci: Advertise the device as modern-only

Eric Auger qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 3 repliesIn review
  2. v12 patches 2 repliesSuperseded

Changes in v2 from the cover letter

- Fix patch #1 commit message typos
- Add Connie's R-b on both patches

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2virtio-iommu: Check gtrees are non null before destroying themhw/virtio/virtio-iommu.c+6 -20 replies
2/2virtio-iommu-pci: force virtio version 1hw/virtio/virtio-iommu-pci.c+1 -13 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchCornelia Huck
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] virtio-iommu-pci: Advertise the device as modern-only

Since commit 9b3a35ec82 ("virtio: verify that legacy support is not accidentally on"), we are forced to use disable-legacy=on when instantiating the virtio-iommu-pci device. This also revealed that the unrealize() function is likely to call g_tree_destroy() on NULL gtrees, which triggers assertions.

Best Regards

Eric

History:
v1 -> v2:
- Fix patch #1 commit message typos
- Add Connie's R-b on both patches

Eric Auger (2):
virtio-iommu: Check gtrees are non null before destroying them
virtio-iommu-pci: force virtio version 1

 hw/virtio/virtio-iommu-pci.c | 2 +-
 hw/virtio/virtio-iommu.c     | 8 ++++++--
 2 files changed, 7 insertions(+), 3 deletions(-)
Signature · 1 line
2.21.3