Skip to content

l2tp: miscellaneous cleanups

Tom Parkin netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6l2tp: remove header length param from l2tp_xmit_skbnet/l2tp/l2tp_core.c net/l2tp/l2tp_core.h net/l2tp/l2tp_eth.c +1 more+9 -100 replies
2/6l2tp: drop data_len argument from l2tp_xmit_corenet/l2tp/l2tp_core.c+2 -30 replies
3/6l2tp: drop net argument from l2tp_tunnel_createnet/l2tp/l2tp_core.c net/l2tp/l2tp_core.h net/l2tp/l2tp_netlink.c +1 more+4 -40 replies
4/6l2tp: capture more tx errors in data plane statsnet/l2tp/l2tp_core.c+37 -340 replies
5/6l2tp: make magic feather checks more usefulnet/l2tp/l2tp_core.c net/l2tp/l2tp_core.h net/l2tp/l2tp_ip.c +2 more+38 -200 replies
6/6l2tp: avoid duplicated code in l2tp_tunnel_closeallnet/l2tp/l2tp_core.c+1 -130 replies

Reviews trailers per patch

None of the 6 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJames Chapman
SeriesR-b
1/6
2/6
3/6
4/6
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH net-next 0/6] l2tp: miscellaneous cleanups

This series of patches makes the following cleanups and improvements to the l2tp code:

* various API tweaks to remove unused parameters from function calls
* lightly refactor the l2tp transmission path to capture more error conditions in the data plane statistics
* repurpose the "magic feather" validation in l2tp to check for sk_user_data (ab)use as opposed to refcount debugging
* remove some duplicated code

Tom Parkin (6):
l2tp: remove header length param from l2tp_xmit_skb
l2tp: drop data_len argument from l2tp_xmit_core
l2tp: drop net argument from l2tp_tunnel_create
l2tp: capture more tx errors in data plane stats
l2tp: make magic feather checks more useful
l2tp: avoid duplicated code in l2tp_tunnel_closeall

 net/l2tp/l2tp_core.c    | 134 +++++++++++++++++++---------------------
 net/l2tp/l2tp_core.h    |  10 ++-
 net/l2tp/l2tp_eth.c     |   2 +-
 net/l2tp/l2tp_ip.c      |   2 +-
 net/l2tp/l2tp_ip6.c     |   2 +-
 net/l2tp/l2tp_netlink.c |   2 +-
 net/l2tp/l2tp_ppp.c     |  15 ++++-
 7 files changed, 87 insertions(+), 80 deletions(-)
Signature · 1 line
2.17.1