Skip to content

qom: Rename macros for consistency (pass 2)

Eduardo Habkost qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 9 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8i8254: Rename TYPE_I8254 to TYPE_ISA_PIThw/timer/i8254.c include/hw/timer/i8254.h+4 -41 reply
2/8i8254: Rename PIT to ISA_PIThw/timer/i8254.c+3 -31 reply
3/8i8259: Rename TYPE_I8259 to TYPE_ISA_I8259hw/intc/i8259.c+5 -51 reply
4/8i8259: Rename PIC to ISA_I8259hw/intc/i8259.c+3 -31 reply
5/8i8259: Rename KVM_PIC to KVM_I8259hw/i386/kvm/i8259.c+3 -31 reply
6/8esp-pci: Rename TYPE_AM53C974_DEVICE to TYPE_AM53C974hw/scsi/esp-pci.c+4 -41 reply
7/8esp-pci: Rename PCI_ESP to AM53C974hw/scsi/esp-pci.c+4 -41 reply
8/8tusb6010: Rename TUSB to TUSB6010hw/usb/tusb6010.c+3 -32 replies

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by.

PatchPhilippe Mathieu-DaudéDaniel P. Berrangé
1/8R-b
2/8R-b
3/8R-b
4/8R-b
5/8R-b
6/8R-b
7/8R-b
8/8R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/8] qom: Rename macros for consistency (pass 2)

Reducing boilerplate QOM code using the new OBJECT_DEFINE_* and OBJECT_DECLARE_* macros is quite difficult when there are multiple ways a TYPE_* constant name is written.

This series renames many type checking macros and/or TYPE_* constants to make sure they are consistent.

This is a second pass of cleanups, incorporating suggestions Philippe and Daniel sent when reviewing the previous series[1].

This series is based on machine-next and can be fetched from:

https://github.com/ehabkost/qemu-hacks work/qom-rename-macros-pass2

[1] https://lore.kernel.org/qemu-devel/[email protected]/

Eduardo Habkost (8):
i8254: Rename TYPE_I8254 to TYPE_ISA_PIT
i8254: Rename PIT to ISA_PIT
i8259: Rename TYPE_I8259 to TYPE_ISA_I8259
i8259: Rename PIC to ISA_I8259
i8259: Rename KVM_PIC to KVM_I8259
esp-pci: Rename TYPE_AM53C974_DEVICE to TYPE_AM53C974
esp-pci: Rename PCI_ESP to AM53C974
tusb6010: Rename TUSB to TUSB6010

 include/hw/timer/i8254.h |  4 ++--
 hw/i386/kvm/i8259.c      |  6 +++---
 hw/intc/i8259.c          | 16 ++++++++--------
 hw/scsi/esp-pci.c        | 16 ++++++++--------
 hw/timer/i8254.c         | 10 +++++-----
 hw/usb/tusb6010.c        |  6 +++---
 6 files changed, 29 insertions(+), 29 deletions(-)
Signature · 1 line
2.26.2