Skip to content

hw/block/nvme: multiple namespaces support

Klaus Jensen qemu-devel 3 versions – Applied

Status from this message: Pushed to nvme-next.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest17 patches 6 repliesApplied
  2. v217 patches 7 repliesSuperseded
  3. v117 patches 22 repliesSuperseded

Changes in v3 from the cover letter

~~~~~~~~~~~~~~

* hw/block/nvme: handle dma errors
Do not retry DMA, just set Controller Fatal Status (CFS). This causes the Linux kernel to most likely disable the controller when running the blktests block/011 test case, which causes some havoc when running blktests, but I have submitted a patch for blktests to fix this. (Keith)

* hw/block/nvme: refactor aio submission
Dropped the unneeded nvme_req_is_write function. (Keith)

* Added R-b's from Keith and Philippe.

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/17hw/block/nvme: fix typo in trace eventhw/block/trace-events+1 -10 replies
2/17pci: pass along the return value of dma_memory_rwinclude/hw/pci/pci.h+1 -20 replies
3/17hw/block/nvme: handle dma errorshw/block/nvme.c hw/block/trace-events+34 -100 replies
4/17hw/block/nvme: commonize nvme_rw error handlinghw/block/nvme.c+9 -70 replies
5/17hw/block/nvme: alignment style fixeshw/block/nvme.c+13 -120 replies
6/17hw/block/nvme: add a lba to bytes helperhw/block/nvme.c hw/block/nvme.h+10 -80 replies
7/17hw/block/nvme: fix endian conversionhw/block/nvme.c+2 -20 replies
8/17hw/block/nvme: add symbolic command name to trace eventshw/block/nvme.c hw/block/nvme.h hw/block/trace-events+36 -60 replies
9/17hw/block/nvme: refactor aio submissionhw/block/nvme.c hw/block/nvme.h hw/block/trace-events+114 -400 replies
10/17hw/block/nvme: default request status to successhw/block/nvme.c+1 -30 replies
11/17hw/block/nvme: harden cmb accesshw/block/nvme.c+6 -10 replies
12/17hw/block/nvme: add support for scatter gather listshw/block/nvme.c hw/block/trace-events include/block/nvme.h+279 -602 replies
13/17hw/block/nvme: add support for sgl bit bucket descriptorhw/block/nvme.c+27 -60 replies
14/17hw/block/nvme: refactor identify active namespace id listhw/block/nvme.c+4 -40 replies
15/17hw/block/nvme: support multiple namespaceshw/block/meson.build hw/block/nvme-ns.c hw/block/nvme-ns.h +3 more+428 -1160 replies
16/17pci: allocate pci id for nvmeMAINTAINERS docs/specs/nvme.txt docs/specs/pci-ids.txt +1 more+26 -00 replies
17/17hw/block/nvme: change controller pci idhw/block/nvme.c hw/block/nvme.h hw/core/machine.c+12 -20 replies

Reviews trailers per patch

15 of 17 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchPhilippe Mathieu-DaudéKeith BuschMichael S. TsirkinMaxim LevitskyMinwoo ImGerd Hoffmann
SeriesR-b
1/17R-b R-b
2/17R-b A-b R-b
3/17
4/17R-b
5/17R-b R-b
6/17R-b
7/17R-b R-b
8/17R-b R-b
9/17
10/17R-b R-b
11/17R-b
12/17R-b
13/17R-b
14/17R-b R-b
15/17R-b R-b
16/17R-b R-b A-b
17/17R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.

Read the v3 thread

Cover letter [PATCH v3 00/17] hw/block/nvme: multiple namespaces support

From: Klaus Jensen <[email protected]>

This is the next round of my patches for the nvme device.

This includes a bit of cleanup and two new features:

* support for scatter/gather lists

* multiple namespaces support through a new nvme-ns device

Finally, the series wraps up with changing the PCI vendor and device ID to get rid of the internal Intel id and as a side-effect get rid of some Linux kernel quirks that no longer applies.

"pci: pass along the return value of dma_memory_rw" has already been posted by Philippe in another series, but since it is not applied yet, I am including it here.

Changes for v3
~~~~~~~~~~~~~~

* hw/block/nvme: handle dma errors
Do not retry DMA, just set Controller Fatal Status (CFS). This causes the Linux kernel to most likely disable the controller when running the blktests block/011 test case, which causes some havoc when running blktests, but I have submitted a patch for blktests to fix this. (Keith)

* hw/block/nvme: refactor aio submission
Dropped the unneeded nvme_req_is_write function. (Keith)

* Added R-b's from Keith and Philippe.

Changes for v2
~~~~~~~~~~~~~~

* Added a new patch ("hw/block/nvme: fix typo in trace event") that does what it says on the tin.

* Dropped the "hw/block/nvme: support multiple parallel aios per request" patch (Keith).

* hw/block/nvme: add symbolic command name to trace events Changed to single quote (Philippe)

* hw/block/nvme: default request status to success Commit message typo fixed (Philippe)

* hw/block/nvme: change controller pci id
Do NOT bump the device id for the legacy Intel id (David)

Gollu Appalanaidu (1):
hw/block/nvme: add support for sgl bit bucket descriptor

Klaus Jensen (16):
hw/block/nvme: fix typo in trace event
pci: pass along the return value of dma_memory_rw hw/block/nvme: handle dma errors
hw/block/nvme: commonize nvme_rw error handling hw/block/nvme: alignment style fixes hw/block/nvme: add a lba to bytes helper hw/block/nvme: fix endian conversion hw/block/nvme: add symbolic command name to trace events hw/block/nvme: refactor aio submission hw/block/nvme: default request status to success hw/block/nvme: harden cmb access
hw/block/nvme: add support for scatter gather lists hw/block/nvme: refactor identify active namespace id list hw/block/nvme: support multiple namespaces
pci: allocate pci id for nvme
hw/block/nvme: change controller pci id

 docs/specs/nvme.txt    |  23 ++
 docs/specs/pci-ids.txt |   1 +
 hw/block/nvme-ns.h     |  74 ++++
 hw/block/nvme.h        |  83 +++-
 include/block/nvme.h   |   6 +-
 include/hw/pci/pci.h   |   4 +-
 hw/block/nvme-ns.c     | 167 ++++++++
 hw/block/nvme.c        | 848 ++++++++++++++++++++++++++++++-----------
 hw/core/machine.c      |   1 +
 MAINTAINERS            |   1 +
 hw/block/meson.build   |   2 +-
 hw/block/trace-events  |  23 +-
 12 files changed, 978 insertions(+), 255 deletions(-)
 create mode 100644 docs/specs/nvme.txt
 create mode 100644 hw/block/nvme-ns.h
 create mode 100644 hw/block/nvme-ns.c
Signature · 1 line
2.28.0