Skip to content

RFC i386: KVM: expand Hyper-V features early

Vitaly Kuznetsov qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 RFC Latest23 patches 2 repliesIn review
  2. v2 RFC19 patches 2 repliesSuperseded
  3. v1 RFC22 patches 14 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/23WIP: update linux/headerslinux-headers/asm-x86/kvm.h linux-headers/linux/kvm.h+44 -30 replies
2/23i386: fill in FEAT_HYPERV_EDX from edx instead of eaxtarget/i386/kvm.c+1 -10 replies
3/23i386: drop x86_cpu_get_supported_feature_word() forward declarationtarget/i386/cpu.c+0 -30 replies
4/23i386: move hyperv_vendor_id initialization to x86_cpu_realizefn()target/i386/cpu.c target/i386/cpu.h target/i386/kvm.c+34 -170 replies
5/23i386: move hyperv_interface_id initialization to x86_cpu_realizefn()target/i386/cpu.c target/i386/cpu.h target/i386/kvm.c+19 -60 replies
6/23i386: move hyperv_version_id initialization to x86_cpu_realizefn()target/i386/cpu.c target/i386/cpu.h target/i386/kvm.c+17 -20 replies
7/23i386: move hyperv_limits initialization to x86_cpu_realizefn()target/i386/cpu.c target/i386/cpu.h target/i386/kvm.c+18 -10 replies
8/23i386: keep hyperv_vendor string up-to-datetarget/i386/cpu.c target/i386/kvm.c+14 -100 replies
9/23i386: invert hyperv_spinlock_attempts setting logic with hv_passthroughtarget/i386/kvm.c+1 -50 replies
10/23i386: always fill Hyper-V CPUID feature leaves from X86CPU datatarget/i386/kvm.c+0 -90 replies
11/23i386: stop using env->features[] for filling Hyper-V CPUIDstarget/i386/cpu.h target/i386/kvm.c+43 -380 replies
12/23i386: introduce hyperv_feature_supported()target/i386/kvm.c+30 -190 replies
13/23i386: introduce hv_cpuid_get_host()target/i386/kvm.c+56 -440 replies
14/23i386: drop FEAT_HYPERV feature leavestarget/i386/cpu.c target/i386/cpu.h target/i386/kvm.c+37 -1660 replies
15/23i386: introduce hv_cpuid_cachetarget/i386/kvm.c+56 -530 replies
16/23i386: split hyperv_handle_properties() into hyperv_expand_features()/hyperv_fill_cpuids()target/i386/kvm.c+24 -100 replies
17/23i386: move eVMCS enablement to hyperv_init_vcpu()target/i386/kvm.c+37 -230 replies
18/23i386: switch hyperv_expand_features() to using error_setg()target/i386/kvm.c+61 -400 replies
19/23i386: adjust the expected KVM_GET_SUPPORTED_HV_CPUID array sizetarget/i386/kvm.c+2 -10 replies
20/23i386: prefer system KVM_GET_SUPPORTED_HV_CPUID ioctl over vCPU's onetarget/i386/kvm.c+13 -40 replies
21/23i386: use global kvm_state in hyperv_enabled() checktarget/i386/kvm.c+1 -20 replies
22/23i386: expand Hyper-V features during CPU feature expansion timetarget/i386/cpu.c target/i386/kvm-stub.c target/i386/kvm.c +1 more+22 -30 replies
23/23i386: provide simple 'hyperv=on' option to x86 machine typesdocs/hyperv.txt hw/i386/x86.c include/hw/i386/x86.h +1 more+59 -02 replies

Reviews trailers per patch

1 of 23 patches has a Reviewed-by or Acked-by.

PatchEduardo Habkost
1/23
2/23
3/23
4/23
5/23
6/23
7/23
8/23
9/23
10/23
11/23
12/23
13/23
14/23
15/23
16/23
17/23
18/23
19/23
20/23
21/23
22/23
23/23R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH RFC v3 00/23] i386: KVM: expand Hyper-V features early

Another week another RFC. KVM patches are still in flight, so RFC again.

Changes since RFCv2:
- Rebase.
- Split "i386: drop FEAT_HYPERV feature leaves" into several patches and re-shuffle patches to minimize the code churn and make it easier to review. [Eduardo]
- Added "i386: provide simple 'hyperv=on' option to x86 machine types" on top.

This pairs with
https://lore.kernel.org/kvm/[email protected]/T/#t

Upper layer tools like libvirt want to figure out which Hyper-V features are supported by the underlying stack (QEMU/KVM) but currently they are unable to do so. We have a nice 'hv_passthrough' CPU flag supported by QEMU but it has no effect on e.g. QMP's

query-cpu-model-expansion type=full model={"name":"host","props":{"hv-passthrough":true}}

command as we parse Hyper-V features after creating KVM vCPUs and not at feature expansion time. To support the use-case we first need to make KVM_GET_SUPPORTED_HV_CPUID ioctl a system-wide ioctl as the existing vCPU version can't be used that early. This is what KVM part does. With that done, we can make early Hyper-V feature expansion (this series).

In addition, add a simple 'hyperv=on' option to x86 machine types which enables (and requires from KVM) all currently supported Hyper-V enlightenments. Unlike 'hv_passthrough' mode, this is going to be migratable.

Vitaly Kuznetsov (23):
WIP: update linux/headers
i386: fill in FEAT_HYPERV_EDX from edx instead of eax
i386: drop x86_cpu_get_supported_feature_word() forward declaration
i386: move hyperv_vendor_id initialization to x86_cpu_realizefn()
i386: move hyperv_interface_id initialization to x86_cpu_realizefn()
i386: move hyperv_version_id initialization to x86_cpu_realizefn()
i386: move hyperv_limits initialization to x86_cpu_realizefn()
i386: keep hyperv_vendor string up-to-date
i386: invert hyperv_spinlock_attempts setting logic with
hv_passthrough
i386: always fill Hyper-V CPUID feature leaves from X86CPU data
i386: stop using env->features[] for filling Hyper-V CPUIDs
i386: introduce hyperv_feature_supported()
i386: introduce hv_cpuid_get_host()
i386: drop FEAT_HYPERV feature leaves
i386: introduce hv_cpuid_cache
i386: split hyperv_handle_properties() into
hyperv_expand_features()/hyperv_fill_cpuids()
i386: move eVMCS enablement to hyperv_init_vcpu()
i386: switch hyperv_expand_features() to using error_setg()
i386: adjust the expected KVM_GET_SUPPORTED_HV_CPUID array size
i386: prefer system KVM_GET_SUPPORTED_HV_CPUID ioctl over vCPU's one
i386: use global kvm_state in hyperv_enabled() check
i386: expand Hyper-V features during CPU feature expansion time
i386: provide simple 'hyperv=on' option to x86 machine types

 docs/hyperv.txt             |   8 +
 hw/i386/x86.c               |  30 ++
 include/hw/i386/x86.h       |   7 +
 linux-headers/asm-x86/kvm.h |  20 ++
 linux-headers/linux/kvm.h   |  27 +-
 target/i386/cpu.c           | 149 ++++------
 target/i386/cpu.h           |  12 +-
 target/i386/kvm-stub.c      |   5 +
 target/i386/kvm.c           | 526 ++++++++++++++++++++----------------
 target/i386/kvm_i386.h      |   1 +
 10 files changed, 457 insertions(+), 328 deletions(-)
Signature · 1 line
2.25.4