rtc: rx8010: use regmap instead of i2c smbus API
Status from this message: Applied, thanks!
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest14 patches 3 repliesApplied
- v211 patches 1 replySuperseded
- v18 patches 7 repliesSuperseded
Changes in v3 from the cover letter
- remove unnecessary error messages when registering the RTC device
- add a patch switching to using the preferred probe_new callback in the I2C driver
- add a patch fixing an issue where the global rtc operations struct is modified depending on the presence of the interrupt
- add a patch removing a stray newline
Patches in v3 Applied
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.
Cover letter [PATCH v3 00/14] rtc: rx8010: use regmap instead of i2c smbus API
From: Bartosz Golaszewski <[email protected]>
This series gets bigger and bigger but I noticed a problem with this driver that looks like stable material so I fixed it as the first patch in the series to make backporting easy.
Other than that, there are new refactoring patches and I removed the unnecessary error messages.
--
I want to use this driver on a platform where the i2c controller doesn't speak SMBUS. This series converts the driver to i2c regmap which can figure out the correct protocol to use.
The actual conversion happens in patch 13. The rest are bugfixes and refactoring.
v1 -> v2:
- s/parentheses/brackets/g
- add a patch switching the driver to using the preferred RTC API
- rework the patch removing magic values
- use range_max and range_min instead of manual range checks
- add a patch adding a helper variable in probe() for client->dev
- add a patch using sizeof(*rx8010) instead of sizeof(struct rx8010_data)
v2 -> v3:
- remove unnecessary error messages when registering the RTC device
- add a patch switching to using the preferred probe_new callback in the I2C driver
- add a patch fixing an issue where the global rtc operations struct is modified depending on the presence of the interrupt
- add a patch removing a stray newline
Bartosz Golaszewski (14):
rtc: rx8010: don't modify the global rtc ops
rtc: rx8010: remove a stray newline
rtc: rx8010: remove unnecessary brackets
rtc: rx8010: consolidate local variables of the same type
rtc: rx8010: use tabs instead of spaces for code formatting
rtc: rx8010: rename ret to err in rx8010_set_time()
rtc: rx8010: don't use magic values for time buffer length
rtc: rx8010: drop unnecessary initialization
rtc: rx8010: use a helper variable for client->dev in probe()
rtc: rx8010: prefer sizeof(*val) over sizeof(struct type_of_val)
rtc: rx8010: switch to using the preferred RTC API
rtc: rx8010: switch to using the preferred i2c API
rtc: rx8010: convert to using regmap
rtc: rx8010: use range checking provided by core RTC code
drivers/rtc/rtc-rx8010.c | 332 +++++++++++++++++---------------------- 1 file changed, 143 insertions(+), 189 deletions(-)
Signature · 1 line
2.26.1