Skip to content

hw: Let DMA/PCI API propagate MemTxResult

Philippe Mathieu-Daudé qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest10 patches 1 replyIn review
  2. v216 patches 2 repliesSuperseded
  3. v113 patches 31 repliesSuperseded

Changes in v3 from the cover letter

- Rebased
- Removed patches adding MemTxAttrs argument to DMA/PCI API (we will discuss them later).

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10pci: pass along the return value of dma_memory_rwinclude/hw/pci/pci.h+1 -20 replies
2/10docs/devel/loads-stores: Add regexp for DMA functionsdocs/devel/loads-stores.rst+2 -00 replies
3/10dma: Document address_space_map/address_space_unmap() prototypesinclude/sysemu/dma.h+28 -10 replies
4/10dma: Let dma_memory_set() propagate MemTxResultinclude/sysemu/dma.h softmmu/dma-helpers.c+18 -40 replies
5/10dma: Let dma_memory_rw() propagate MemTxResultinclude/sysemu/dma.h+22 -80 replies
6/10dma: Let dma_memory_read() propagate MemTxResultinclude/sysemu/dma.h+17 -40 replies
7/10dma: Let dma_memory_write() propagate MemTxResultinclude/sysemu/dma.h+18 -40 replies
8/10pci: Let pci_dma_rw() propagate MemTxResultinclude/hw/pci/pci.h+16 -20 replies
9/10pci: Let pci_dma_read() propagate MemTxResultinclude/hw/pci/pci.h+14 -20 replies
10/10pci: Let pci_dma_write() propagate MemTxResultinclude/hw/pci/pci.h+14 -20 replies

Reviews trailers per patch

All 10 patches have a Reviewed-by or Acked-by.

PatchRichard HendersonEdgar E. IglesiasLi QiangPhilippe Mathieu-DaudéMichael S. TsirkinKeith Busch
1/10R-b R-b R-b R-b R-b A-b
2/10R-b R-b
3/10R-b R-b
4/10R-b R-b R-b
5/10R-b R-b R-b
6/10R-b R-b R-b
7/10R-b R-b R-b
8/10R-b R-b
9/10R-b R-b
10/10R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.

Read the v3 thread

Cover letter [PATCH RESEND v3 00/10] hw: Let DMA/PCI API propagate MemTxResult

Currently the MemTxResult return value is not propagated, so lost. The motivation behind this series is to make the API more robust to enforce correct use by the consumers.

All series reviewed.

Since v2:
- Rebased
- Removed patches adding MemTxAttrs argument to DMA/PCI API (we will discuss them later).

v2:
https://www.mail-archive.com/[email protected]/msg746761.html

The DMA API propagates MemTxResult:
- MEMTX_OK,
- MEMTX_device_ERROR,
- MEMTX_DECODE_ERROR.

Let the PCI DMA API propagate them, as they are clearer than an undocumented 'int'.

Supersedes: <[email protected]>

Klaus Jensen (1):
pci: pass along the return value of dma_memory_rw

Philippe Mathieu-Daudé (9):
docs/devel/loads-stores: Add regexp for DMA functions
dma: Document address_space_map/address_space_unmap() prototypes
dma: Let dma_memory_set() propagate MemTxResult
dma: Let dma_memory_rw() propagate MemTxResult
dma: Let dma_memory_read() propagate MemTxResult
dma: Let dma_memory_write() propagate MemTxResult
pci: Let pci_dma_rw() propagate MemTxResult
pci: Let pci_dma_read() propagate MemTxResult
pci: Let pci_dma_write() propagate MemTxResult

 docs/devel/loads-stores.rst |   2 +
 include/hw/pci/pci.h        |  53 +++++++++++++---
 include/sysemu/dma.h        | 117 ++++++++++++++++++++++++++++++------
 softmmu/dma-helpers.c       |   7 ++-
 4 files changed, 150 insertions(+), 29 deletions(-)
Signature · 1 line
2.26.2