Skip to content

Include makefiles from GLOBAL_PATCH_DIR

Yann E. MORIN buildroot 1 version New

Get series with b4
b4 am 20200905203213.GA14354@scaer

Versions newest first

  1. v2 Latest0 of 2 patches 0 repliesNew

Patches in v2 No applies recorded yet

None of the 2 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [Buildroot] [PATCH v2 0/2] Include makefiles from GLOBAL_PATCH_DIR

J?r?my, All,

On 2019-11-09 19:55 +0100, J?r?my Rosen spake thusly:

Quoted 11 lines

V2:
* fix includes happening multiple times on host+target packages
* change name of included makefiles from .mk to .smk (see commit for details)

Note that the first patch might be usefull independently of the (more controversial) second patch.

I am opened to changing the .smk to any pattern you suggest I am not sure where to fit this in the documentation. suggestions welcomed

As was discussed when we met in Lyon, and elsewhere on the list (sorry, I can't dig the thread now), we already outlined a better solution, which is to provide a generic way for a package to be extended or even completely overriden from a br2-external tree.

I know it's been quite a long time, but I hope you do remember that discussion, and hopefully you can also dig the thread on the list...

I've now marked that series as rejected.

Thanks.

Quoted 27 lines

J?r?my Rosen (2):
allow .smk files as includes in packages
Include makefiles from GLOBAL_PATCH_DIR

 package/pkg-autotools.mk     |  1 +
 package/pkg-cmake.mk         |  1 +
 package/pkg-generic.mk       |  8 ++++++--
 package/pkg-golang.mk        |  1 +
 package/pkg-kconfig.mk       |  1 +
 package/pkg-kernel-module.mk |  1 +
 package/pkg-luarocks.mk      |  1 +
 package/pkg-meson.mk         |  1 +
 package/pkg-perl.mk          |  1 +
 package/pkg-python.mk        |  1 +
 package/pkg-rebar.mk         |  1 +
 package/pkg-utils.mk         | 21 ++++++++++++++++++++-
 package/pkg-virtual.mk       |  1 +
 package/pkg-waf.mk           |  1 +
 14 files changed, 38 insertions(+), 3 deletions(-)
Signature · 6 lines
2.24.0.rc1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'