block/export: Add infrastructure and QAPI for block exports
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest31 patches 11 repliesIn review
- v129 patches 23 repliesSuperseded
Changes in v2 from the cover letter
- Rebased on current master
- Fixed assumption of &blk_exp_nbd instead of drv in generic code [Max]
- Documented blk_exp_request_shutdown() better [Max]
- iotests 140: Fixed race between QMP return value and event [Max]
- Improved the commit message for patch 26
- Removed copy&paste error in deprecated.rst [Max]
- iotests: Take Sequence instead of positional arguments in qemu_tool_pipe_and_status() [Max]
- iotests: Separate patch for qemu_nbd_list_log [Max]
- iotests 307: [Max]
* Allow more image formats
* Use sock_dir for the socket
* Use f-strings instead of % operator
* Log events after deleting an export
* Test force removing an export
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/31 | nbd: Remove unused nbd_export_get_blockdev()include/ nbd/ | +0 | 0 replies | |
| 2/31 | qapi: Create block-export moduleblock/ blockdev-nbd.c include/ +6 more | +184 | 0 replies | |
| 3/31 | qapi: Rename BlockExport to BlockExportOptionsblock/ blockdev-nbd.c qapi/ +1 more | +14 | 0 replies | |
| 4/31 | block/export: Add BlockExport infrastructure and block-export-addblock/ block/ block/ +6 more | +133 | 1 reply | |
| 5/31 | qemu-storage-daemon: Use qmp_block_export_add()storage-daemon/ | +1 | 0 replies | |
| 6/31 | qemu-nbd: Use raw block driver for --offsetblockdev-nbd.c include/ nbd/ +1 more | +31 | 0 replies | |
| 7/31 | block/export: Remove magic from block-export-addblock/ blockdev-nbd.c include/ +3 more | +67 | 0 replies | |
| 8/31 | nbd: Add max-connections to nbd-server-startblock/ blockdev-nbd.c include/ +2 more | +39 | 0 replies | |
| 9/31 | nbd: Add writethrough to block-export-addblockdev-nbd.c qapi/ | +11 | 0 replies | |
| 10/31 | nbd: Remove NBDExport.close callbackblockdev-nbd.c include/ nbd/ +1 more | +7 | 0 replies | |
| 11/31 | qemu-nbd: Use blk_exp_add() to create the exportblockdev-nbd.c include/ qemu-nbd.c | +30 | 0 replies | |
| 12/31 | nbd/server: Simplify export shutdownnbd/ | +4 | 0 replies | |
| 13/31 | block/export: Move refcount from NBDExport to BlockExportblock/ blockdev-nbd.c include/ +2 more | +63 | 0 replies | |
| 14/31 | block/export: Move AioContext from NBDExport to BlockExportblock/ include/ nbd/ | +18 | 0 replies | |
| 15/31 | block/export: Add node-name to BlockExportOptionsblock/ blockdev-nbd.c qapi/ +1 more | +58 | 0 replies | |
| 16/31 | block/export: Allocate BlockExport in blk_exp_add()block/ blockdev-nbd.c include/ +2 more | +57 | 0 replies | |
| 17/31 | block/export: Add blk_exp_close_all(_type)block.c block/ blockdev-nbd.c +4 more | +107 | 0 replies | |
| 18/31 | block/export: Add 'id' option to block-export-addblock/ blockdev-nbd.c include/ +4 more | +39 | 0 replies | |
| 19/31 | block/export: Move strong user reference to block_exportsblock/ blockdev-nbd.c include/ +1 more | +14 | 0 replies | |
| 20/31 | block/export: Add block-export-delblock/ block/ blockdev-nbd.c +4 more | +77 | 0 replies | |
| 21/31 | block/export: Add BLOCK_EXPORT_DELETED eventblock/ qapi/ tests/ +2 more | +27 | 1 reply | |
| 22/31 | block/export: Move blk to BlockExportblock/ include/ nbd/ | +28 | 0 replies | |
| 23/31 | block/export: Create BlockBackend in blk_exp_add()block/ blockdev-nbd.c include/ +1 more | +63 | 0 replies | |
| 24/31 | block/export: Add query-block-exportsblock/ qapi/ | +55 | 0 replies | |
| 25/31 | block/export: Move writable to BlockExportOptionsblock/ blockdev-nbd.c nbd/ +2 more | +32 | 0 replies | |
| 26/31 | nbd: Merge nbd_export_new() and nbd_export_create()blockdev-nbd.c include/ nbd/ | +45 | 1 reply | |
| 27/31 | nbd: Deprecate nbd-server-add/removedocs/ qapi/ | +15 | 1 reply | |
| 28/31 | iotests: Factor out qemu_tool_pipe_and_status()tests/ | +23 | 1 reply | |
| 29/31 | iotests: Introduce qemu_nbd_list_log()tests/ | +12 | 1 reply | |
| 30/31 | iotests: Allow supported and unsupported formats at the same timetests/ | +1 | 1 reply | |
| 31/31 | iotests: Test block-export-* QMP interfacetests/ tests/ tests/ | +257 | 1 reply |
Reviews trailers per patch
All 31 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Max Reitz | Eric Blake | Stefan Hajnoczi |
|---|---|---|---|
| Series | A-b | ||
| 1/31 | R-b | R-b | |
| 2/31 | R-b | R-b | |
| 3/31 | R-b | R-b | |
| 4/31 | R-b | R-b | |
| 5/31 | R-b | R-b | |
| 6/31 | R-b | R-b | |
| 7/31 | R-b | ||
| 8/31 | R-b | R-b | |
| 9/31 | R-b | ||
| 10/31 | R-b | R-b | |
| 11/31 | R-b | ||
| 12/31 | R-b | R-b | |
| 13/31 | R-b | ||
| 14/31 | R-b | ||
| 15/31 | R-b | ||
| 16/31 | R-b | ||
| 17/31 | R-b | ||
| 18/31 | R-b | ||
| 19/31 | R-b | ||
| 20/31 | R-b | ||
| 21/31 | R-b | ||
| 22/31 | R-b | ||
| 23/31 | R-b | ||
| 24/31 | R-b | ||
| 25/31 | R-b | ||
| 26/31 | R-b | ||
| 27/31 | R-b | ||
| 28/31 | R-b | ||
| 29/31 | R-b | ||
| 30/31 | R-b | ||
| 31/31 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v2 00/31] block/export: Add infrastructure and QAPI for block exports
We are planning to add more block export types than just NBD in the near future (e.g. vhost-user-blk and FUSE). This series lays the ground for this with some generic block export infrastructure and QAPI interfaces that will allow managing all of them (for now add/remove/query).
As a side effect, qemu-storage-daemon can now map --export directly to the block-export-add QMP command, similar to other command line options. The built-in NBD servers also gains new options that bring it at least a little closer to feature parity with qemu-nbd.
v2:
- Rebased on current master
- Fixed assumption of &blk_exp_nbd instead of drv in generic code [Max]
- Documented blk_exp_request_shutdown() better [Max]
- iotests 140: Fixed race between QMP return value and event [Max]
- Improved the commit message for patch 26
- Removed copy&paste error in deprecated.rst [Max]
- iotests: Take Sequence instead of positional arguments in qemu_tool_pipe_and_status() [Max]
- iotests: Separate patch for qemu_nbd_list_log [Max]
- iotests 307: [Max]
* Allow more image formats
* Use sock_dir for the socket
* Use f-strings instead of % operator
* Log events after deleting an export
* Test force removing an export
Kevin Wolf (31):
nbd: Remove unused nbd_export_get_blockdev()
qapi: Create block-export module
qapi: Rename BlockExport to BlockExportOptions block/export: Add BlockExport infrastructure and block-export-add
qemu-storage-daemon: Use qmp_block_export_add()
qemu-nbd: Use raw block driver for --offset block/export: Remove magic from block-export-add
nbd: Add max-connections to nbd-server-start
nbd: Add writethrough to block-export-add
nbd: Remove NBDExport.close callback
qemu-nbd: Use blk_exp_add() to create the export nbd/server: Simplify export shutdown
block/export: Move refcount from NBDExport to BlockExport block/export: Move AioContext from NBDExport to BlockExport block/export: Add node-name to BlockExportOptions block/export: Allocate BlockExport in blk_exp_add() block/export: Add blk_exp_close_all(_type) block/export: Add 'id' option to block-export-add block/export: Move strong user reference to block_exports block/export: Add block-export-del
block/export: Add BLOCK_EXPORT_DELETED event block/export: Move blk to BlockExport
block/export: Create BlockBackend in blk_exp_add() block/export: Add query-block-exports
block/export: Move writable to BlockExportOptions
nbd: Merge nbd_export_new() and nbd_export_create()
nbd: Deprecate nbd-server-add/remove
iotests: Factor out qemu_tool_pipe_and_status()
iotests: Introduce qemu_nbd_list_log()
iotests: Allow supported and unsupported formats at the same time
iotests: Test block-export-* QMP interface
qapi/block-core.json | 166 -------------- qapi/block-export.json | 291 ++++++++++++++++++++++++ qapi/qapi-schema.json | 1 + docs/system/deprecated.rst | 6 + include/block/export.h | 89 ++++++++ include/block/nbd.h | 22 +- block.c | 2 +- block/export/export.c | 325 +++++++++++++++++++++++++++ block/monitor/block-hmp-cmds.c | 13 +- blockdev-nbd.c | 171 +++++++------- nbd/server.c | 309 +++++++++++-------------- qemu-nbd.c | 67 +++--- storage-daemon/qemu-storage-daemon.c | 27 +-- tests/qemu-iotests/iotests.py | 68 +++--- block/export/meson.build | 1 + block/meson.build | 2 + meson.build | 2 +- qapi/meson.build | 4 +- storage-daemon/qapi/qapi-schema.json | 1 + tests/qemu-iotests/140 | 9 +- tests/qemu-iotests/140.out | 2 +- tests/qemu-iotests/223.out | 8 +- tests/qemu-iotests/307 | 132 +++++++++++ tests/qemu-iotests/307.out | 124 ++++++++++ tests/qemu-iotests/group | 1 + 25 files changed, 1311 insertions(+), 532 deletions(-) create mode 100644 qapi/block-export.json create mode 100644 include/block/export.h create mode 100644 block/export/export.c create mode 100644 block/export/meson.build create mode 100755 tests/qemu-iotests/307 create mode 100644 tests/qemu-iotests/307.out
Signature · 1 line
2.25.4