Skip to content

btrfs: add read-only support for subpage sector size

Qu Wenruo linux-btrfs 8 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest18 patches 33 repliesIn review
  2. v4 posting 2/218 patches 49 repliesSuperseded
  3. v3 posting 2/222 patches 9 repliesSuperseded
Earlier versions · 5
VersionPostedPatchesRepliesStatus
v2 posting 2/218 patches44 repliesSuperseded
v4 posting 1/268 patches28 repliesSuperseded
v3 posting 1/249 patches0 repliesSuperseded
v2 posting 1/219 patches36 repliesSuperseded
v117 patches25 repliesSuperseded

Changes in v5 from the cover letter

- Use the updated version from David as base
Most comment/commit message update should be kept as is.

- A new separate patch to move UNMAPPED bit set timing

- New comment on why we need to prealloc subpage inside a loop Mostly for further 16K page size support, where we can have eb across multiple pages.

- Remove one patch which is too RW specific
Since it introduces functional change which only makes sense for RW support, it's not a good idea to include it in RO support.

- Error handling fixes
Great thanks to Josef.

- Refactor btrfs_subpage allocation/freeing
Now we have btrfs_alloc_subpage() and btrfs_free_subpage() helpers to do all the allocation/freeing.
It's pretty easy to convert to kmem_cache using above helpers. (already internally tested using kmem_cache without problem, in fact
it's all the problems found in kmem_cache test leads to the new interface)

- Use btrfs_subpage::eb_refs to replace old under_alloc This makes checking whether the page has any eb left much easier.

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/18btrfs: merge PAGE_CLEAR_DIRTY and PAGE_SET_WRITEBACK to PAGE_START_WRITEBACKfs/btrfs/extent_io.c fs/btrfs/extent_io.h fs/btrfs/inode.c+18 -261 reply
2/18btrfs: set UNMAPPED bit early in btrfs_clone_extent_buffer() for subpage supportfs/btrfs/extent_io.c+7 -21 reply
3/18btrfs: introduce the skeleton of btrfs_subpage structurefs/btrfs/Makefile fs/btrfs/subpage.c fs/btrfs/subpage.h +1 more+78 -20 replies
4/18btrfs: make attach_extent_buffer_page() handle subpage casefs/btrfs/extent_io.c fs/btrfs/subpage.c fs/btrfs/subpage.h+96 -131 reply
5/18btrfs: make grab_extent_buffer_from_page() handle subpage casefs/btrfs/extent_io.c+11 -21 reply
6/18btrfs: support subpage for extent buffer page releasefs/btrfs/extent_io.c fs/btrfs/subpage.c fs/btrfs/subpage.h+133 -162 replies
7/18btrfs: attach private to dummy extent buffer pagesfs/btrfs/extent_io.c+8 -11 reply
8/18btrfs: introduce helpers for subpage uptodate statusfs/btrfs/subpage.c fs/btrfs/subpage.h+142 -01 reply
9/18btrfs: introduce helpers for subpage error statusfs/btrfs/subpage.c fs/btrfs/subpage.h+31 -01 reply
10/18btrfs: support subpage in set/clear_extent_buffer_uptodate()fs/btrfs/extent_io.c+7 -41 reply
11/18btrfs: support subpage in btrfs_clone_extent_bufferfs/btrfs/extent_io.c+1 -21 reply
12/18btrfs: support subpage in try_release_extent_buffer()fs/btrfs/extent_io.c+104 -21 reply
13/18btrfs: introduce read_extent_buffer_subpage()fs/btrfs/extent_io.c+70 -01 reply
14/18btrfs: support subpage in endio_readpage_update_page_status()fs/btrfs/extent_io.c+15 -61 reply
15/18btrfs: introduce subpage metadata validation checkfs/btrfs/disk-io.c+57 -01 reply
16/18btrfs: introduce btrfs_subpage for data inodesfs/btrfs/compression.c fs/btrfs/extent_io.c fs/btrfs/extent_io.h +6 more+103 -332 replies
17/18btrfs: integrate page status update for data read path into begin/end_page_read()fs/btrfs/extent_io.c fs/btrfs/subpage.c fs/btrfs/subpage.h+78 -242 replies
18/18btrfs: allow RO mount of 4K sector size fs on 64K page systemfs/btrfs/disk-io.c fs/btrfs/super.c+28 -32 replies

Reviews trailers per patch

16 of 18 patches have a Reviewed-by or Acked-by.

PatchDavid SterbaJosef Bacik
1/18R-b R-b
2/18R-b
3/18R-b R-b
4/18R-b R-b
5/18R-b R-b
6/18R-b
7/18R-b R-b
8/18R-b R-b
9/18R-b R-b
10/18R-b R-b
11/18R-b R-b
12/18R-b R-b
13/18R-b R-b
14/18R-b R-b
15/18R-b R-b
16/18
17/18
18/18R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 00/18] btrfs: add read-only support for subpage sector size

Patches can be fetched from github:
https://github.com/adam900710/linux/tree/subpage
Currently the branch also contains partial RW data support (still some ordered extent and data csum mismatch problems)

Great thanks to David/Nikolay/Josef for their effort reviewing and merging the preparation patches into misc-next.

=== What works ===
Just from the patchset:
- Data read
Both regular and compressed data, with csum check.

- Metadata read

This means, with these patchset, 64K page systems can at least mount btrfs with 4K sector size read-only.
This should provide the ability to migrate data at least.

While on the github branch, there are already experimental RW supports, there are still ordered extent related bugs for me to fix. Thus only the RO part is sent for review and testing.

=== Patchset structure ===
Patch 01~02: Preparation patches which don't have functional change
Patch 03~12: Subpage metadata allocation and freeing
Patch 13~15: Subpage metadata read path
Patch 16~17: Subpage data read path
Patch 18: Enable subpage RO support

=== Changelog ===
v1:
- Separate the main implementation from previous huge patchset Huge patchset doesn't make much sense.

- Use bitmap implementation
Now page::private will be a pointer to btrfs_subpage structure, which contains bitmaps for various page status.

v2:
- Use page::private as btrfs_subpage for extra info
This replace old extent io tree based solution, which reduces latency and don't require memory allocation for its operations.

- Cherry-pick new preparation patches from RW development Those new preparation patches improves the readability by their own.

v3:
- Make dummy extent buffer to follow the same subpage accessors Fsstress exposed several ASSERT() for dummy extent buffers. It turns out we need to make dummy extent buffer to own the same btrfs_subpage structure to make eb accessors to work properly

- Two new small __process_pages_contig() related preparation patches One to make __process_pages_contig() to enhance the error handling path for locked_page, one to merge one macro.

- Extent buffers refs count update
Except try_release_extent_buffer(), all other eb uses will try to increase the ref count of the eb.
For try_release_extent_buffer(), the eb refs check will happen inside the rcu critical section to avoid eb being freed.

- Comment updates
Addressing the comments from the mail list.

v4:
- Get rid of btrfs_subpage::tree_block_bitmap
This is to reduce lock complexity (no need to bother extra subpage lock for metadata, all locks are existing locks)
Now eb looking up mostly depends on radix tree, with small help from btrfs_subpage::under_alloc.
Now I haven't experieneced metadata related problems any more during my local fsstress tests.

- Fix a race where metadata page dirty bit can race Fixed in the metadata RW patchset though.

- Rebased to latest misc-next branch
With 4 patches removed, as they are already in misc-next.

v5:
- Use the updated version from David as base
Most comment/commit message update should be kept as is.

- A new separate patch to move UNMAPPED bit set timing

- New comment on why we need to prealloc subpage inside a loop Mostly for further 16K page size support, where we can have eb across multiple pages.

- Remove one patch which is too RW specific
Since it introduces functional change which only makes sense for RW support, it's not a good idea to include it in RO support.

- Error handling fixes
Great thanks to Josef.

- Refactor btrfs_subpage allocation/freeing
Now we have btrfs_alloc_subpage() and btrfs_free_subpage() helpers to do all the allocation/freeing.
It's pretty easy to convert to kmem_cache using above helpers. (already internally tested using kmem_cache without problem, in fact
it's all the problems found in kmem_cache test leads to the new interface)

- Use btrfs_subpage::eb_refs to replace old under_alloc This makes checking whether the page has any eb left much easier.

Qu Wenruo (18):
btrfs: merge PAGE_CLEAR_DIRTY and PAGE_SET_WRITEBACK to
PAGE_START_WRITEBACK
btrfs: set UNMAPPED bit early in btrfs_clone_extent_buffer() for
subpage support
btrfs: introduce the skeleton of btrfs_subpage structure
btrfs: make attach_extent_buffer_page() handle subpage case
btrfs: make grab_extent_buffer_from_page() handle subpage case
btrfs: support subpage for extent buffer page release
btrfs: attach private to dummy extent buffer pages
btrfs: introduce helpers for subpage uptodate status
btrfs: introduce helpers for subpage error status
btrfs: support subpage in set/clear_extent_buffer_uptodate()
btrfs: support subpage in btrfs_clone_extent_buffer
btrfs: support subpage in try_release_extent_buffer()
btrfs: introduce read_extent_buffer_subpage()
btrfs: support subpage in endio_readpage_update_page_status()
btrfs: introduce subpage metadata validation check
btrfs: introduce btrfs_subpage for data inodes
btrfs: integrate page status update for data read path into
begin/end_page_read()
btrfs: allow RO mount of 4K sector size fs on 64K page system

 fs/btrfs/Makefile           |   3 +-
 fs/btrfs/compression.c      |  10 +-
 fs/btrfs/disk-io.c          |  81 +++++-
 fs/btrfs/extent_io.c        | 485 ++++++++++++++++++++++++++++++++----
 fs/btrfs/extent_io.h        |  15 +-
 fs/btrfs/file.c             |  24 +-
 fs/btrfs/free-space-cache.c |  15 +-
 fs/btrfs/inode.c            |  42 ++--
 fs/btrfs/ioctl.c            |   8 +-
 fs/btrfs/reflink.c          |   5 +-
 fs/btrfs/relocation.c       |  11 +-
 fs/btrfs/subpage.c          | 278 +++++++++++++++++++++
 fs/btrfs/subpage.h          |  92 +++++++
 fs/btrfs/super.c            |   8 +-
 14 files changed, 964 insertions(+), 113 deletions(-)
 create mode 100644 fs/btrfs/subpage.c
 create mode 100644 fs/btrfs/subpage.h
Signature · 1 line
2.30.0