Skip to content

net: ipa: wake up system on RX available

Alex Elder lkml netdev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest7 patches 1 replyIn review
  2. v27 patches 6 repliesSuperseded
  3. v15 patches 4 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7net: ipa: use refcount_t for IPA clock reference countdrivers/net/ipa/ipa_clock.c+7 -70 replies
2/7net: ipa: replace ipa->suspend_ref with a flag bitdrivers/net/ipa/ipa.h drivers/net/ipa/ipa_main.c+19 -90 replies
3/7net: ipa: manage endpoints separate from clockdrivers/net/ipa/ipa_clock.c drivers/net/ipa/ipa_main.c+12 -100 replies
4/7net: ipa: use device_init_wakeup()drivers/net/ipa/ipa.h drivers/net/ipa/ipa_main.c+18 -260 replies
5/7net: ipa: repurpose CLOCK_HELD flagdrivers/net/ipa/ipa.h drivers/net/ipa/ipa_main.c+10 -100 replies
6/7net: ipa: enable wakeup on IPA interruptdrivers/net/ipa/ipa_interrupt.c+14 -00 replies
7/7net: ipa: do not enable GSI interrupt for wakeupdrivers/net/ipa/gsi.c drivers/net/ipa/gsi.h+4 -140 replies

Reviews trailers per patch

4 of 7 patches have a Reviewed-by or Acked-by.

PatchBjorn Andersson
1/7
2/7
3/7R-b
4/7R-b
5/7
6/7R-b
7/7R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH net-next v3 0/7] net: ipa: wake up system on RX available

This series arranges for the IPA driver to wake up a suspended system if the IPA hardware has a packet to deliver to the AP.

Version 2 replaced the first patch from version 1 with three patches, in response to David Miller's feedback. And based on Bjorn Andersson's feedback on version 2, this version reworks the tracking of IPA clock references. As a result, we no longer need a flag to determine whether a "don't' suspend" clock reference is held (though an bit in a bitmask is still used for a different purpose).

In summary:
- A refcount_t is used to track IPA clock references where an atomic_t was previously used. (This may go away soon as well, with upcoming work to implement runtime PM.)
- We no longer track whether a special reference has been taken to avoid suspending IPA.
- A bit in a bitmask is used to ensure we only trigger a system resume once per system suspend.
And from the original series:
- Suspending endpoints only occurs when suspending the driver, not when dropping the last clock reference. Resuming endpoints is also disconnected from starting the clock.
- The IPA SUSPEND interrupt is now a wakeup interrupt. If it fires, it schedules a system resume operation.
- The GSI interrupt is no longer a wakeup interrupt.

-Alex

Alex Elder (7):
net: ipa: use refcount_t for IPA clock reference count
net: ipa: replace ipa->suspend_ref with a flag bit
net: ipa: manage endpoints separate from clock
net: ipa: use device_init_wakeup()
net: ipa: repurpose CLOCK_HELD flag
net: ipa: enable wakeup on IPA interrupt
net: ipa: do not enable GSI interrupt for wakeup

 drivers/net/ipa/gsi.c           | 17 +++------
 drivers/net/ipa/gsi.h           |  1 -
 drivers/net/ipa/ipa.h           | 16 ++++++---
 drivers/net/ipa/ipa_clock.c     | 28 ++++++---------
 drivers/net/ipa/ipa_interrupt.c | 14 ++++++++
 drivers/net/ipa/ipa_main.c      | 64 +++++++++++++++++----------------
 6 files changed, 74 insertions(+), 66 deletions(-)
Signature · 1 line
2.20.1