Skip to content

virtiofsd: Announce submounts to the guest

Max Reitz qemu-devel virtio-fs 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest7 patches 5 repliesIn review
  2. v27 patches 3 repliesSuperseded
  3. v18 patches 4 repliesSuperseded

Changes in v3 from the cover letter

- Patch 7:
- Replace specific has_passwordless_sudo() function by a generic has_cmd() function that can check for any shell command whether it works or not

- Let this function catch exceptions, too, so if sudo is not present altogether, the test doesn’t fail but is skipped as intended [Eduardo]

- (Add has_cmds() to run multiple instances of has_cmd() in a decorator)

- Skip the test not only if “sudo -n true” doesn’t work, but also check for ssh-keygen, bash, losetup, mkfs.xfs, and mount, which are some other tools we need that might not be present on the host

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7virtiofsd: Check FUSE_SUBMOUNTStools/virtiofsd/fuse_common.h tools/virtiofsd/fuse_lowlevel.c+10 -00 replies
2/7virtiofsd: Add attr_flags to fuse_entry_paramtools/virtiofsd/fuse_lowlevel.c tools/virtiofsd/fuse_lowlevel.h+7 -00 replies
3/7meson.build: Check for statx()meson.build+16 -00 replies
4/7virtiofsd: Add mount ID to the lo_inode keytools/virtiofsd/passthrough_ll.c tools/virtiofsd/passthrough_seccomp.c+86 -100 replies
5/7virtiofsd: Announce sub-mount pointstools/virtiofsd/helper.c tools/virtiofsd/passthrough_ll.c+23 -03 replies
6/7tests/acceptance/boot_linux: Accept SSH pubkeytests/acceptance/boot_linux.py+7 -60 replies
7/7tests/acceptance: Add virtiofs_submounts.pytests/acceptance/virtiofs_submounts.py tests/acceptance/virtiofs_submounts.py.data/cleanup.sh tests/acceptance/virtiofs_submounts.py.data/guest-cleanup.sh +2 more+662 -01 reply

Reviews trailers per patch

6 of 7 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchStefan HajnocziPhilippe Mathieu-DaudéWillian RampazzoEduardo HabkostMiklos Szeredi
SeriesR-b
1/7R-b
2/7R-b
3/7R-b
4/7R-b
5/7R-b
6/7R-b R-b R-b
7/7T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v3 thread

Cover letter [PATCH v3 0/7] virtiofsd: Announce submounts to the guest

RFC: https://www.redhat.com/archives/virtio-fs/2020-May/msg00024.html
v1: https://lists.nongnu.org/archive/html/qemu-devel/2020-09/msg03598.html
v2: https://lists.nongnu.org/archive/html/qemu-devel/2020-10/msg09117.html

Branch: https://github.com/XanClic/qemu.git virtiofs-submounts-v4
Branch: https://git.xanclic.moe/XanClic/qemu.git virtiofs-submounts-v4

Hi,

In an effort to cut this cover letter shorter, I’ll defer to the cover letter of v2 linked above concerning the general description of this series, and limit myself to describing the differences from v2:

v3:
- Patch 7:
- Replace specific has_passwordless_sudo() function by a generic has_cmd() function that can check for any shell command whether it works or not

- Let this function catch exceptions, too, so if sudo is not present altogether, the test doesn’t fail but is skipped as intended [Eduardo]

- (Add has_cmds() to run multiple instances of has_cmd() in a decorator)

- Skip the test not only if “sudo -n true” doesn’t work, but also check for ssh-keygen, bash, losetup, mkfs.xfs, and mount, which are some other tools we need that might not be present on the host

git-backport-diff against v2:

Key:
[----] : patches are identical
[####] : number of functional differences between upstream/downstream patch [down] : patch is downstream-only
The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively

001/7:[----] [--] 'virtiofsd: Check FUSE_SUBMOUNTS' 002/7:[----] [--] 'virtiofsd: Add attr_flags to fuse_entry_param' 003/7:[----] [--] 'meson.build: Check for statx()' 004/7:[----] [--] 'virtiofsd: Add mount ID to the lo_inode key' 005/7:[----] [--] 'virtiofsd: Announce sub-mount points' 006/7:[----] [--] 'tests/acceptance/boot_linux: Accept SSH pubkey' 007/7:[0042] [FC] 'tests/acceptance: Add virtiofs_submounts.py'

Max Reitz (7):
virtiofsd: Check FUSE_SUBMOUNTS
virtiofsd: Add attr_flags to fuse_entry_param
meson.build: Check for statx()
virtiofsd: Add mount ID to the lo_inode key
virtiofsd: Announce sub-mount points
tests/acceptance/boot_linux: Accept SSH pubkey
tests/acceptance: Add virtiofs_submounts.py

 meson.build                                   |  16 +
 tools/virtiofsd/fuse_common.h                 |   7 +
 tools/virtiofsd/fuse_lowlevel.h               |   5 +
 tools/virtiofsd/fuse_lowlevel.c               |   5 +
 tools/virtiofsd/helper.c                      |   1 +
 tools/virtiofsd/passthrough_ll.c              | 117 ++++++-
 tools/virtiofsd/passthrough_seccomp.c         |   1 +
 tests/acceptance/boot_linux.py                |  13 +-
 tests/acceptance/virtiofs_submounts.py        | 321 ++++++++++++++++++
 .../virtiofs_submounts.py.data/cleanup.sh     |  46 +++
 .../guest-cleanup.sh                          |  30 ++
 .../virtiofs_submounts.py.data/guest.sh       | 138 ++++++++
 .../virtiofs_submounts.py.data/host.sh        | 127 +++++++
 13 files changed, 811 insertions(+), 16 deletions(-)
 create mode 100644 tests/acceptance/virtiofs_submounts.py
 create mode 100644 tests/acceptance/virtiofs_submounts.py.data/cleanup.sh
 create mode 100644 tests/acceptance/virtiofs_submounts.py.data/guest-cleanup.sh
 create mode 100644 tests/acceptance/virtiofs_submounts.py.data/guest.sh
 create mode 100644 tests/acceptance/virtiofs_submounts.py.data/host.sh
Signature · 1 line
2.26.2