KVM: arm64: Fix handling of S1PTW
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest2 patches 2 repliesIn review
- v11 patch 3 repliesSuperseded
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | KVM: arm64: Assume write fault on S1PTW permission fault on instruction fetcharch/ arch/ arch/ | +13 | 1 reply | |
| 2/2 | KVM: arm64: Remove S1PTW check from kvm_vcpu_dabt_iswrite()arch/ | +2 | 0 replies |
Reviews trailers per patch
None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Will Deacon |
|---|---|
| Series | R-b |
| 1/2 | |
| 2/2 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/2] KVM: arm64: Fix handling of S1PTW
I recently managed to trigger an interesting failure mode, where a guest would be stuck on an instruction abort due to a permission fault. Interestingly enough, this IABT had S1PTW set in the ESR, indicating that it was trying to *write* to the PT. We fix it by adding the execute permission (it's an IABT, after all...), and going nowhere fast.
Note that it can only happen on a system that can perform automatic updates of the page table flags.
This small series fixes the issue by revamping the S1PTW handling in the context of execution faults. The first patch fixes the bug, and is definitely a stable candidate. The second patch is merely a cleanup, which can wait.
Tested on an A55-based board.
* From v1:
- Rename kvm_vcpu_dabt_iss1tw() to kvm_vcpu_abt_iss1tw()
- Don't overload kvm_vcpu_trap_is_iabt()
- Introduce kvm_vcpu_trap_is_exec_fault()
Marc Zyngier (2):
KVM: arm64: Assume write fault on S1PTW permission fault on
instruction fetch
KVM: arm64: Remove S1PTW check from kvm_vcpu_dabt_iswrite()
arch/arm64/include/asm/kvm_emulate.h | 14 +++++++++++--- arch/arm64/kvm/hyp/include/hyp/switch.h | 2 +- arch/arm64/kvm/mmu.c | 4 ++-- 3 files changed, 14 insertions(+), 6 deletions(-)
Signature · 6 lines
2.28.0 _______________________________________________ kvmarm mailing list [email protected] https://lists.cs.columbia.edu/mailman/listinfo/kvmarm