Skip to content

RFC ARMv8 Tune reorg

Jon Mason openembedded-core 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest6 patches 9 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6arm64: set BASE_LIB to lib64meta/conf/machine/include/arm/arch-arm64.inc meta/conf/machine/include/arm/arch-armv8-2a.inc meta/conf/machine/include/arm/arch-armv8a.inc +9 more+2 -215 replies
2/6arch-armv8-2a.inc: Add Cortex-A55 tuningsmeta/conf/machine/include/arm/arch-armv8-2a.inc meta/conf/machine/include/tune-cortexa55.inc+23 -204 replies
3/6arch-armv8a.inc: Add existing tuningsmeta/conf/machine/include/arm/arch-armv8a.inc meta/conf/machine/include/tune-cortexa32.inc meta/conf/machine/include/tune-cortexa35.inc +7 more+140 -1480 replies
4/6qemuarm64: change tuningmeta/conf/machine/qemuarm64.conf+2 -10 replies
5/6arch-armv8a.inc: Add tunes for supported ARMv8a coresmeta/conf/machine/include/arm/arch-armv8a.inc+43 -00 replies
6/6arch-armv8-2a.inc: Add tunes for supported ARMv8.2a coresmeta/conf/machine/include/arm/arch-armv8-2a.inc+127 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [meta-oe][RFC 0/6] ARMv8 Tune reorg

There is a large number of Arm Tune files located in meta/conf/machine/include/, and to support the current and upcoming Arm cores, more are needed. Adding more files is simply going to make it harder to find the relevant ones for an OE/YP developer/user. Also, there are problems with stale and erroneous configs (see my previous series), which will only be exacerbated by having more files.

I am proposing a reorganization of the existing tune files by including them in the generic family include file. For example, the tune-cortexa55.inc would be moved into arch-armv8-2a.inc, and tune-cortexa57.inc would be moved into arch-armv8a.inc. This reduces the number of files from 12 to 2 for ARMv8a, and that is excluding the 13 I am adding in this series that would otherwise be unique files.

To use, simply add
...
DEFAULTTUNE ?= "neoversen1"
require conf/machine/include/arm/arch-armv8-2a.inc
...

Which is arguably what should be done anyway (instead of taking the default of the tune include file).
See the qemuarm64 patch in the series for a working example.

Of course, by removing the existing tune files, current users are going to break. A simple script can be written to use sed (or similar) to replace the relevant parts for those users that would be affected (at least for those that are in the layer index and update regularly).

If it is agreed that this is a good idea, I could do something similar for ARMv7 (its just a bit more painful due to all the permutations).

As far as testing, I have built and run testimage on qemuarm64. I've built every QEMU machine in meta, as well as every machine in meta-arm-bsp (modified to use the new code). There are no observed issues.

Thanks,
Jon

---

Jon Mason (6):
arm64: set BASE_LIB to lib64
arch-armv8-2a.inc: Add Cortex-A55 tunings arch-armv8a.inc: Add existing tunings
qemuarm64: change tuning
arch-armv8a.inc: Add tunes for supported ARMv8a cores arch-armv8-2a.inc: Add tunes for supported ARMv8.2a cores

 meta/conf/machine/include/arm/arch-arm64.inc  |   3 +-
 .../machine/include/arm/arch-armv8-2a.inc     | 160 ++++++++++++++-
 meta/conf/machine/include/arm/arch-armv8a.inc | 189 +++++++++++++++++-
 meta/conf/machine/include/tune-cortexa32.inc  |  18 --
 meta/conf/machine/include/tune-cortexa35.inc  |  17 --
 meta/conf/machine/include/tune-cortexa53.inc  |  18 --
 meta/conf/machine/include/tune-cortexa55.inc  |  13 --
 .../include/tune-cortexa57-cortexa53.inc      |  15 --
 meta/conf/machine/include/tune-cortexa57.inc  |  17 --
 .../include/tune-cortexa72-cortexa53.inc      |  20 --
 meta/conf/machine/include/tune-cortexa72.inc  |  13 --
 .../include/tune-cortexa73-cortexa53.inc      |  20 --
 meta/conf/machine/include/tune-thunderx.inc   |  19 --
 meta/conf/machine/qemuarm64.conf              |   3 +-
 14 files changed, 336 insertions(+), 189 deletions(-)
 delete mode 100644 meta/conf/machine/include/tune-cortexa32.inc
 delete mode 100644 meta/conf/machine/include/tune-cortexa35.inc
 delete mode 100644 meta/conf/machine/include/tune-cortexa53.inc
 delete mode 100644 meta/conf/machine/include/tune-cortexa55.inc
 delete mode 100644 meta/conf/machine/include/tune-cortexa57-cortexa53.inc
 delete mode 100644 meta/conf/machine/include/tune-cortexa57.inc
 delete mode 100644 meta/conf/machine/include/tune-cortexa72-cortexa53.inc
 delete mode 100644 meta/conf/machine/include/tune-cortexa72.inc
 delete mode 100644 meta/conf/machine/include/tune-cortexa73-cortexa53.inc
 delete mode 100644 meta/conf/machine/include/tune-thunderx.inc
Signature · 1 line
2.20.1