Skip to content

Enlarge tracepoints in the display component

Rodrigo Siqueira amd-gfx dri-devel lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 7 repliesIn review
  2. v13 patches 0 repliesSuperseded

Changes in v2 from the cover letter

- I added another patch for capturing the clock state for different display architecture.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4drm/amd/display: Rework registers tracepointdrivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_trace.h+24 -312 replies
2/4drm/amd/display: Add tracepoint for amdgpu_dmdrivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_trace.h+304 -00 replies
3/4drm/amd/display: Add pipe_state tracepointdrivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_trace.h drivers/gpu/drm/amd/display/dc/core/dc.c drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c+195 -52 replies
4/4drm/amd/display: Add tracepoint for capturing clocks statedrivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_trace.h drivers/gpu/drm/amd/display/dc/clk_mgr/dce112/dce112_clk_mgr.c drivers/gpu/drm/amd/display/dc/clk_mgr/dcn10/rv1_clk_mgr.c +4 more+224 -00 replies

Reviews trailers per patch

1 of 4 patches has a Reviewed-by or Acked-by.

PatchNicholas Kazlauskas
1/4R-b
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/4] Enlarge tracepoints in the display component

Debug issues related to display can be a challenge due to the complexity around this topic and different source of information might help in this process. We already have support for tracepoints inside the display component, i.e., we have the basic functionalities available and we just need to expand it in order to make it more valuable for debugging. For this reason, this patchset reworks part of the current tracepoint options and add different sets of tracing inside amdgpu_dm, display core, and DCN10. The first patch of this series just rework part of the current tracepoints and the last set of patches introduces new tracepoints.

This first patchset version is functional. Please, let me know what I can improve in the current version but also let me know what kind of tracepoint I can add for the next version.

Finally, I want to highlight that this work is based on a set of patches originally made by Nicholas Kazlauskas.

Change in V2:
- I added another patch for capturing the clock state for different display architecture.

Rodrigo Siqueira (4):
drm/amd/display: Rework registers tracepoint drm/amd/display: Add tracepoint for amdgpu_dm drm/amd/display: Add pipe_state tracepoint drm/amd/display: Add tracepoint for capturing clocks state

 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |  17 +
 .../amd/display/amdgpu_dm/amdgpu_dm_trace.h   | 712 +++++++++++++++++-
 .../dc/clk_mgr/dce112/dce112_clk_mgr.c        |   5 +
 .../display/dc/clk_mgr/dcn10/rv1_clk_mgr.c    |   4 +
 .../display/dc/clk_mgr/dcn20/dcn20_clk_mgr.c  |   4 +
 .../amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c |   4 +
 .../display/dc/clk_mgr/dcn30/dcn30_clk_mgr.c  |   4 +
 drivers/gpu/drm/amd/display/dc/core/dc.c      |  11 +
 .../gpu/drm/amd/display/dc/dce/dce_clk_mgr.c  |   5 +
 .../amd/display/dc/dcn10/dcn10_hw_sequencer.c |  17 +-
 10 files changed, 747 insertions(+), 36 deletions(-)
Signature · 6 lines
2.28.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel