Skip to content

abi breakage checks for meson

Conor Walsh dpdk-dev 4 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest4 patches 0 repliesNew
  2. v34 patches 6 repliesSuperseded
  3. v24 patches 0 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v14 patches0 repliesSuperseded

Changes in v4 from the cover letter

- Reworked both Python scripts to use more native Python functions and modules.
- Python scripts are now in line with how other Python scripts in DPDK are structured.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4devtools: bug fix for gen-abi.shdevtools/gen-abi.sh+1 -50 replies
2/4devtools: add generation of compressed abi dump archivesdevtools/gen-abi-tarball.py+142 -00 replies
3/4buildtools: add script to setup abi checks for mesonbuildtools/abi-setup.py+141 -00 replies
4/4build: add abi breakage checks to mesonbuildtools/meson.build config/meson.build drivers/meson.build +2 more+63 -00 replies

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchRay Kinsella
SeriesA-b A-b A-b A-b A-b A-b
1/4
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [dpdk-dev] [PATCH v4 0/4] abi breakage checks for meson

This patchset allows developers to check ABI breakages during build time. Currently checking that the DPDK ABI has not changed before up-streaming code is not intuitive. The current method, requires the contributor to use either the test-build.sh and test-meson-build.sh tools, along side some environmental variables to test their changes. Contributors in many cases are either unaware or unable to do this themselves, leading to a potentially serious situation where they are unknowingly up-streaming code that breaks the ABI. These breakages are then caught by Travis, but it is more efficient if this is caught locally before up-streaming.

---
v4:
- Reworked both Python scripts to use more native Python functions and modules.
- Python scripts are now in line with how other Python scripts in DPDK are structured.

v3:
- Fix for bug which now allows meson < 0.48.0 to be used
- Various coding style changes throughout
- Minor bug fixes to the various meson.build files

v2: Spelling mistake, corrected spelling of environmental

Conor Walsh (4):
devtools: bug fix for gen-abi.sh
devtools: add generation of compressed abi dump archives
buildtools: add script to setup abi checks for meson
build: add abi breakage checks to meson

 buildtools/abi-setup.py     | 141 +++++++++++++++++++++++++++++++++++
 buildtools/meson.build      |  18 +++++
 config/meson.build          |  15 ++++
 devtools/gen-abi-tarball.py | 142 ++++++++++++++++++++++++++++++++++++
 devtools/gen-abi.sh         |   6 +-
 drivers/meson.build         |  14 ++++
 lib/meson.build             |  14 ++++
 meson_options.txt           |   2 +
 8 files changed, 347 insertions(+), 5 deletions(-)
 create mode 100755 buildtools/abi-setup.py
 create mode 100755 devtools/gen-abi-tarball.py
Signature · 1 line
2.25.1