Skip to content

chardev: QOM cleanups

Eduardo Habkost qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest18 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/18chardev: Move PARALLEL_CHARDEV macro to common codechardev/char-parallel.c+3 -60 replies
2/18chardev: Move ParallelChardev typedef to common codechardev/char-parallel.c+5 -40 replies
3/18chardev: Use DECLARE_INSTANCE_CHECKER macro for PARALLEL_CHARDEVchardev/char-parallel.c+2 -20 replies
4/18chardev: Rename MOUSE_CHARDEV to CHARDEV_MSMOUSEchardev/msmouse.c+6 -60 replies
5/18chardev: Rename BAUM_CHARDEV to CHARDEV_BRAILLEchardev/baum.c+7 -70 replies
6/18chardev: Rename FD_CHARDEV to CHARDEV_FDchardev/char-fd.c chardev/char-serial.c include/chardev/char-fd.h+9 -90 replies
7/18chardev: Rename MUX_CHARDEV to CHARDEV_MUXchardev/char-fe.c chardev/char-mux.c chardev/char.c +1 more+15 -150 replies
8/18chardev: Rename PARALLEL_CHARDEV to CHARDEV_PARALLELchardev/char-parallel.c+6 -60 replies
9/18chardev: Rename PTY_CHARDEV to CHARDEV_PTYchardev/char-pty.c+11 -110 replies
10/18chardev: Rename RINGBUF_CHARDEV to CHARDEV_RINGBUFchardev/char-ringbuf.c+6 -60 replies
11/18chardev: Rename SOCKET_CHARDEV to CHARDEV_SOCKETchardev/char-socket.c+34 -340 replies
12/18chardev: Rename SPICE_CHARDEV to CHARDEV_SPICEchardev/spice.c include/chardev/spice.h+9 -90 replies
13/18chardev: Rename TESTDEV_CHARDEV to CHARDEV_TESTDEVchardev/testdev.c+2 -20 replies
14/18chardev: Rename UDP_CHARDEV to CHARDEV_UDPchardev/char-udp.c+7 -70 replies
15/18chardev: Rename VC_CHARDEV to CHARDEV_VCui/console.c ui/gtk.c ui/spice-app.c+10 -100 replies
16/18chardev: Rename WCTABLET_CHARDEV to CHARDEV_WCTABLETchardev/wctablet.c+6 -60 replies
17/18chardev: Rename WIN_CHARDEV to CHARDEV_WINchardev/char-pipe.c chardev/char-win.c include/chardev/char-win.h+9 -90 replies
18/18chardev: Rename WIN_STDIO_CHARDEV to CHARDEV_WIN_STDIOchardev/char-win-stdio.c+7 -70 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/18] chardev: QOM cleanups

Some chardev QOM cleanup patches had to be dropped from my queue due to build erros introduced by code movements across ifdef boundaries at char-parallel.c. This series redo the changes from those patches, but the macro renames are now a little different:

In this version I have decided to rename the type checking macros from *_CHARDEV to CHARDEV_* instead of renaming tye TYPE_CHARDEV_* constants to TYPE_*_CHARDEV, to make the identifiers actually match the QOM type name strings ("chardev-*").

Eduardo Habkost (18):
chardev: Move PARALLEL_CHARDEV macro to common code
chardev: Move ParallelChardev typedef to common code
chardev: Use DECLARE_INSTANCE_CHECKER macro for PARALLEL_CHARDEV
chardev: Rename MOUSE_CHARDEV to CHARDEV_MSMOUSE
chardev: Rename BAUM_CHARDEV to CHARDEV_BRAILLE
chardev: Rename FD_CHARDEV to CHARDEV_FD
chardev: Rename MUX_CHARDEV to CHARDEV_MUX
chardev: Rename PARALLEL_CHARDEV to CHARDEV_PARALLEL
chardev: Rename PTY_CHARDEV to CHARDEV_PTY
chardev: Rename RINGBUF_CHARDEV to CHARDEV_RINGBUF
chardev: Rename SOCKET_CHARDEV to CHARDEV_SOCKET
chardev: Rename SPICE_CHARDEV to CHARDEV_SPICE
chardev: Rename TESTDEV_CHARDEV to CHARDEV_TESTDEV
chardev: Rename UDP_CHARDEV to CHARDEV_UDP
chardev: Rename VC_CHARDEV to CHARDEV_VC
chardev: Rename WCTABLET_CHARDEV to CHARDEV_WCTABLET
chardev: Rename WIN_CHARDEV to CHARDEV_WIN
chardev: Rename WIN_STDIO_CHARDEV to CHARDEV_WIN_STDIO

 chardev/chardev-internal.h |  2 +-
 include/chardev/char-fd.h  |  2 +-
 include/chardev/char-win.h |  2 +-
 include/chardev/spice.h    |  2 +-
 chardev/baum.c             | 14 ++++----
 chardev/char-fd.c          | 14 ++++----
 chardev/char-fe.c          |  4 +--
 chardev/char-mux.c         | 22 ++++++------
 chardev/char-parallel.c    | 28 ++++++++--------
 chardev/char-pipe.c        |  2 +-
 chardev/char-pty.c         | 22 ++++++------
 chardev/char-ringbuf.c     | 12 +++----
 chardev/char-serial.c      |  2 +-
 chardev/char-socket.c      | 68 +++++++++++++++++++-------------------
 chardev/char-udp.c         | 14 ++++----
 chardev/char-win-stdio.c   | 14 ++++----
 chardev/char-win.c         | 14 ++++----
 chardev/char.c             |  2 +-
 chardev/msmouse.c          | 12 +++----
 chardev/spice.c            | 16 ++++-----
 chardev/testdev.c          |  4 +--
 chardev/wctablet.c         | 12 +++----
 ui/console.c               | 10 +++---
 ui/gtk.c                   |  8 ++---
 ui/spice-app.c             |  2 +-
 25 files changed, 151 insertions(+), 153 deletions(-)
Signature · 1 line
2.26.2