Skip to content

RFC mm: allow mapping accounted kernel pages to userspace

Roman Gushchin linux-mm lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest5 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5mm: memcg/slab: fix racy access to page->mem_cgroup in mem_cgroup_from_obj()mm/memcontrol.c+11 -00 replies
2/5mm: memcontrol: use helpers to access page's memcg datainclude/linux/memcontrol.h include/linux/mm.h include/linux/mm_types.h +9 more+124 -1171 reply
3/5mm: memcontrol/slab: use helpers to access slab page's memcg_datainclude/linux/memcontrol.h mm/memcontrol.c mm/slab.h+53 -262 replies
4/5mm: introduce page memcg flagsinclude/linux/memcontrol.h+23 -110 replies
5/5mm: convert page kmemcg type to a page memcg flaginclude/linux/memcontrol.h include/linux/page-flags.h mm/memcontrol.c +1 more+39 -230 replies

Reviews trailers per patch

2 of 5 patches have a Reviewed-by or Acked-by.

PatchShakeel Butt
1/5
2/5R-b
3/5R-b
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH rfc 0/5] mm: allow mapping accounted kernel pages to userspace

Currently a non-slab kernel page which has been charged to a memory cgroup can't be mapped to userspace. The underlying reason is simple:
PageKmemcg flag is defined as a page type (like buddy, offline, etc), so it takes a bit from a page->mapped counter. Pages with a type set can't be mapped to userspace.

But in general the kmemcg flag has nothing to do with mapping to userspace. It only means that the page has been accounted by the page allocator, so it has to be properly uncharged on release.

Some bpf maps are mapping the vmalloc-based memory to userspace, and their memory can't be accounted because of this implementation detail.

This patchset removes this limitation by moving the PageKmemcg flag into one of the free bits of the page->mem_cgroup pointer. Also it formalizes all accesses to the page->mem_cgroup and page->obj_cgroups using new helpers, adds several checks and removes a couple of obsolete functions. As the result the code became more robust with fewer open-coded bits tricks.

The first patch in the series is a bugfix, which I already sent separately. Including it in rfc to make the whole series compile.

Roman Gushchin (5):
mm: memcg/slab: fix racy access to page->mem_cgroup in
mem_cgroup_from_obj()
mm: memcontrol: use helpers to access page's memcg data
mm: memcontrol/slab: use helpers to access slab page's memcg_data
mm: introduce page memcg flags
mm: convert page kmemcg type to a page memcg flag

 include/linux/memcontrol.h       | 161 +++++++++++++++++++++++++++++--
 include/linux/mm.h               |  22 -----
 include/linux/mm_types.h         |   5 +-
 include/linux/page-flags.h       |  11 +--
 include/trace/events/writeback.h |   2 +-
 mm/debug.c                       |   4 +-
 mm/huge_memory.c                 |   4 +-
 mm/memcontrol.c                  | 116 ++++++++++------------
 mm/migrate.c                     |   2 +-
 mm/page_alloc.c                  |   6 +-
 mm/page_io.c                     |   4 +-
 mm/slab.h                        |  28 +-----
 mm/workingset.c                  |   4 +-
 13 files changed, 221 insertions(+), 148 deletions(-)
Signature · 1 line
2.26.2