syscalls: Use common variants structure
Get series with b4
b4 am 20200911114536.GA14099@dell5510Versions newest first
- v1 Latest0 of 16 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 16 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [LTP] [PATCH 00/16] syscalls: Use common variants structure
Hi Viresh,
Quoted 35 lines · Petr Vorel
Quoted 29 lines
Hi Viresh,
One of the commits fails on various tests [1].Some failures (I haven't checked all):
* missing
nfds_t(<poll.h> is probably from old commits) [2]:CC testcases/kernel/syscalls/mq_open/mq_open01
In file included from../../../../include/time64_variants.h:13,from /usr/src/ltp/testcases/kernel/syscalls/mq_timedreceive/../utils/mq_timed.h:10, from mq_timedreceive01.c:17:
/usr/include/sys/poll.h:1:2: warning: #warning redirecting incorrect #include <sys/poll.h> to <poll.h> [-Wcpp]
1 | #warning redirecting incorrect #include <sys/poll.h> to <poll.h>
| ^~~~~~~
In file included from/usr/src/ltp/testcases/kernel/syscalls/mq_timedreceive/../utils/mq_timed.h:10,from mq_timedreceive01.c:17:
../../../../include/time64_variants.h:41:35: error: unknown type name 'nfds_t' 41 | int (*ppoll)(struct pollfd *fds,nfds_tnfds, void*tmo_p,* <
libaio.h> not found [3]:
BUILD libltpnewipc.a
make[6]: Nothing to be done for 'all'.
In file included from/usr/src/ltp/testcases/kernel/syscalls/ipc/semop/semop02.c:29:
In file included from In file included from/usr/src/ltp/testcases/kernel/syscalls/ipc/semop/semop01.c:15:
In file included from/usr/src/ltp/testcases/kernel/syscalls/ipc/semop/semop.h:7:/usr/src/ltp/include/time64_variants.h:10:10: fatal error: /usr/src/ltp/testcases/kernel/syscalls/ipc/semop/semop.h'libaio.h' file not
found
:7:/usr/src/ltp/include/time64_variants.h:10:10: fatal error: 'libaio.h' file#include <libaio.h>Quoted 4 lines
^~~~~~~~~~not
found
#include <libaio.h>
Quoted 1 line
I didn't get any of these on my x86 box :(
This is also confusing for me.
Maybe enable travis CI builds for your ltp fork? You contribute a lot, catching bugs early would be great.
Kind regards,
Petr