Skip to content

hw: usb: hcd-ohci: fix oob access and loop issues

P J P qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 2 repliesIn review
  2. v11 patch 4 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2hw: usb: hcd-ohci: check len and frame_number variableshw/usb/hcd-ohci.c+22 -20 replies
2/2hw: usb: hcd-ohci: check for processed TD before retirehw/usb/hcd-ohci.c+4 -01 reply

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchLi Qiang
1/2
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] hw: usb: hcd-ohci: fix oob access and loop issues

From: Prasad J Pandit <[email protected]>

Hello,

* While servicing transfer descriptors(TD) in ohci_service[_iso]_td routines, it may lead to out-of-bounds access and/or infinite loop issues, as the OHCI controller driver may supply malicious values to derive frame_number, start_addr, end_addr etc. variables.

* This series breaks earlier single patch into two.
One for an out-of-bounds access issue and another to fix infinite loop case.
-> https://lists.nongnu.org/archive/html/qemu-devel/2020-09/msg05145.html

Thank you.
--
Prasad J Pandit (2):
hw: usb: hcd-ohci: check len and frame_number variables
hw: usb: hcd-ohci: check for processed TD before retire

 hw/usb/hcd-ohci.c | 28 ++++++++++++++++++++++++++--
 1 file changed, 26 insertions(+), 2 deletions(-)

--
2.26.2