Skip to content

Reclaim TIF_IA32 and TIF_X32

Gabriel Krisman Bertazi lkml 3 versions – Applied

Status from this message: The following commit has been merged into the x86/cleanups branch of tip:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest10 patches 3 repliesApplied
  2. v29 patches 11 repliesSuperseded
  3. v16 patches 3 repliesSuperseded

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/10x86: events: Avoid TIF_IA32 when checking 64bit modearch/x86/events/core.c arch/x86/events/intel/ds.c arch/x86/events/intel/lbr.c +1 more+4 -40 replies
2/10x86: Simplify compat syscall userspace allocationarch/x86/include/asm/compat.h+7 -80 replies
3/10x86: oprofile: Avoid TIF_IA32 when checking 64bit modearch/x86/oprofile/backtrace.c+1 -10 replies
4/10x86: elf: Use e_machine to choose DLINFO in compatarch/x86/include/asm/elf.h+1 -10 replies
5/10elf: Expose ELF header in compat_start_threadfs/binfmt_elf.c fs/compat_binfmt_elf.c include/linux/elf.h+13 -30 replies
6/10x86: elf: Use e_machine to select start_thread for x32arch/x86/include/asm/elf.h arch/x86/kernel/process_64.c+5 -51 reply
7/10elf: Expose ELF header on arch_setup_additional_pagesfs/binfmt_elf.c fs/compat_binfmt_elf.c include/linux/elf.h+14 -40 replies
8/10x86: elf: Use e_machine to select additional_pages between x32arch/x86/entry/vdso/vma.c arch/x86/include/asm/elf.h+6 -40 replies
9/10x86: Convert mmu context ia32_compat into a proper flags fieldarch/x86/entry/vsyscall/vsyscall_64.c arch/x86/include/asm/mmu.h arch/x86/include/asm/mmu_context.h +1 more+17 -101 reply
10/10x86: Reclaim TIF_IA32 and TIF_X32arch/x86/include/asm/thread_info.h arch/x86/kernel/process_64.c+0 -101 reply

Reviews trailers per patch

4 of 10 patches have a Reviewed-by or Acked-by.

PatchPeter Zijlstra (Intel)Andy Lutomirski
1/10A-b
2/10
3/10
4/10R-b
5/10
6/10R-b
7/10
8/10
9/10A-b
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 00/10] Reclaim TIF_IA32 and TIF_X32

This is the third version of the patch to reclaim those TI flags. The main difference from v2 is that it exports the elf32 headers in the macros in a proper way, instead of doing some magic to use them.

Andy, I didn't follow (my understanding of) your suggestion to expose the elf32 headers because by doing that in compat_start_thread would mean also doing it in start_thread, but the later is not ELF specific. The mechanism I used, which solves the issue and I hope is not over-complex is the same that SET_PERSONALITY does, so there is precedent. It also has the benefit that we don't need to touch other architecture functions. Do you think in this patch series is fine?

This also drops the vmx patch, since that is being reworked by Sean and Andy, and my patch doesn't change its behavior.

* original cover letter:

We are running out of TI flags for x86. This patchset removes several usages of TIF_IA32 and TIF_x32 in preparation to reclaim these flags. After these cleanups, there is still one more user for both of them, which I need to take a better look before removing.

Many of the ideas for this patchset came from Andy Lutomirski (Thank you!)

These were tested by exercising these paths with x32 and ia32 binaries.

Gabriel Krisman Bertazi (10):
x86: events: Avoid TIF_IA32 when checking 64bit mode
x86: Simplify compat syscall userspace allocation
x86: oprofile: Avoid TIF_IA32 when checking 64bit mode
x86: elf: Use e_machine to choose DLINFO in compat
elf: Expose ELF header in compat_start_thread
x86: elf: Use e_machine to select start_thread for x32
elf: Expose ELF header on arch_setup_additional_pages
x86: elf: Use e_machine to select additional_pages between x32
x86: Convert mmu context ia32_compat into a proper flags field
x86: Reclaim TIF_IA32 and TIF_X32

 arch/x86/entry/vdso/vma.c             |  4 ++--
 arch/x86/entry/vsyscall/vsyscall_64.c |  2 +-
 arch/x86/events/core.c                |  2 +-
 arch/x86/events/intel/ds.c            |  2 +-
 arch/x86/events/intel/lbr.c           |  2 +-
 arch/x86/include/asm/compat.h         | 15 +++++++-------
 arch/x86/include/asm/elf.h            | 13 ++++++++-----
 arch/x86/include/asm/mmu.h            |  6 ++++--
 arch/x86/include/asm/mmu_context.h    |  2 +-
 arch/x86/include/asm/thread_info.h    |  4 ----
 arch/x86/kernel/perf_regs.c           |  2 +-
 arch/x86/kernel/process_64.c          | 28 +++++++++++++--------------
 arch/x86/oprofile/backtrace.c         |  2 +-
 fs/binfmt_elf.c                       |  4 ++--
 fs/compat_binfmt_elf.c                | 20 ++++++++++++++-----
 include/linux/elf.h                   | 10 ++++++++++
 16 files changed, 68 insertions(+), 50 deletions(-)
Signature · 1 line
2.28.0