Skip to content

vhost-vsock: force virtio version 1

Stefano Garzarella qemu-devel 5 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest4 patches 0 repliesNew
  2. v44 patches 4 repliesSuperseded
  3. v34 patches 7 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v21 patch8 repliesSuperseded
v11 patch1 replySuperseded

Changes in v5 from the cover letter

- Patch 2: added a phrase about transitional device in the commit message [Cornelia]
- All patches reviewed by Cornelia

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4virtio: skip legacy support check on machine types less than 5.1hw/core/machine.c hw/s390x/virtio-ccw.c hw/virtio/virtio-pci.c +2 more+34 -50 replies
2/4vhost-vsock-pci: force virtio version 1hw/virtio/vhost-vsock-pci.c+9 -10 replies
3/4vhost-user-vsock-pci: force virtio version 1hw/virtio/vhost-user-vsock-pci.c+3 -10 replies
4/4vhost-vsock-ccw: force virtio version 1hw/s390x/vhost-vsock-ccw.c+12 -00 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchCornelia Huck
1/4R-b
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/4] vhost-vsock: force virtio version 1

v5:
- Patch 2: added a phrase about transitional device in the commit message [Cornelia]
- All patches reviewed by Cornelia

v4: https://lists.gnu.org/archive/html/qemu-devel/2020-09/msg07353.html
v3: https://lists.gnu.org/archive/html/qemu-devel/2020-09/msg06549.html
v2: https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg04437.html
v1: https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg04373.html

Recently changes in QEMU 5.1 requires to set 'disable-legacy=on' on vhost-vsock-pci and vhost-user-vsock-pci devices:

    $ ./qemu-system-x86_64 ... -device vhost-vsock-pci,guest-cid=5
        qemu-system-x86_64: -device vhost-vsock-pci,guest-cid=5:
        device is modern-only, use disable-legacy=on

As discussed with Cornelia [2], this series forces virtio version 1 to vhost-vsock-pci, vhost-user-vsock-pci, and vhost-vsock-ccw devices.

virtio-vsock was introduced after the release of VIRTIO 1.0 specifications, so it should be 'modern-only'.
In addition Cornelia verified that forcing a legacy mode on vhost-vsock-pci device using x86-64 host and s390x guest, so with different endianness, produces strange behaviours.

This series should be merged in stable branch since it fixes migration issues with QEMU 5.1:
- we skip legacy support check in the old machine types (< 5.1)
- we force virtio version 1 for vhost-vsock-pci and vhost-vsock-ccw devices only in the new machine types (>= 5.1). vhost-user-vsock-pci was introduced in 5.1 and doesn't support migration, so we forced virtio version 1 in any case,

Thanks,
Stefano

[1] https://lists.gnu.org/archive/html/qemu-devel/2020-09/msg05312.html
[2] https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg02515.html

Stefano Garzarella (4):
virtio: skip legacy support check on machine types less than 5.1
vhost-vsock-pci: force virtio version 1
vhost-user-vsock-pci: force virtio version 1
vhost-vsock-ccw: force virtio version 1

 include/hw/virtio/virtio.h       |  2 ++
 hw/core/machine.c                |  1 +
 hw/s390x/vhost-vsock-ccw.c       | 12 ++++++++++++
 hw/s390x/virtio-ccw.c            | 15 ++++++++++++---
 hw/virtio/vhost-user-vsock-pci.c |  4 +++-
 hw/virtio/vhost-vsock-pci.c      | 10 +++++++++-
 hw/virtio/virtio-pci.c           | 14 ++++++++++++--
 hw/virtio/virtio.c               |  7 +++++++
 8 files changed, 58 insertions(+), 7 deletions(-)
Signature · 1 line
2.26.2