Skip to content

pause frame stats

Jakub Kicinski netdev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest7 patches 1 replyIn review
  2. v26 patches 3 repliesSuperseded
  3. v15 patches 6 repliesSuperseded

Changes in v3 from the cover letter

- rename the ctx variable to policy_ctx
- instead of returning the flags policy save it to a member of struct nl_context, for potential reuse. Also we don't have to worry about returning flags and negative errors from the read helper this way :)

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7update UAPI header copiesuapi/linux/genetlink.h uapi/linux/netlink.h+15 -00 replies
2/7pause: add --json supportnetlink/coalesce.c netlink/netlink.h netlink/pause.c+51 -200 replies
3/7separate FLAGS out in -hethtool.c+6 -30 replies
4/7add support for stats in subcommandsethtool.8.in ethtool.c internal.h+16 -00 replies
5/7netlink: prepare for more per-op infonetlink/netlink.c netlink/netlink.h+18 -130 replies
6/7netlink: use policy dumping to check if stats flag is supportednetlink/msgbuff.h netlink/netlink.c netlink/netlink.h+164 -00 replies
7/7pause: add support for dumping statisticsnetlink/pause.c+66 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH ethtool v3 0/7] pause frame stats

Hi!

Sorry about the delay from v2.

This set adds support for pause frame statistics.

First pause frame info is extended to support --json.

Pause stats are first of this kind of statistics so add support for a new flag (--include-statistics).

Next add support for dumping policy to check if the statistics flag is supported for a given subcommand.

Last but not least - display statistics.

v3:
- rename the ctx variable to policy_ctx
- instead of returning the flags policy save it to a member of struct nl_context, for potential reuse. Also we don't have to worry about returning flags and negative errors from the read helper this way :)

Jakub Kicinski (7):
update UAPI header copies
pause: add --json support
separate FLAGS out in -h
add support for stats in subcommands
netlink: prepare for more per-op info
netlink: use policy dumping to check if stats flag is supported
pause: add support for dumping statistics

 ethtool.8.in           |   7 ++
 ethtool.c              |  17 +++-
 internal.h             |   1 +
 netlink/coalesce.c     |   6 +-
 netlink/msgbuff.h      |   6 ++
 netlink/netlink.c      | 179 ++++++++++++++++++++++++++++++++++++++---
 netlink/netlink.h      |  31 +++++--
 netlink/pause.c        | 111 ++++++++++++++++++++++---
 uapi/linux/genetlink.h |  11 +++
 uapi/linux/netlink.h   |   4 +
 10 files changed, 336 insertions(+), 37 deletions(-)
Signature · 1 line
2.26.2