Bluetooth: Add new MGMT interface for advertising add
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest6 patches 0 repliesNew
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | Bluetooth: Add helper to set adv datainclude/ net/ | +34 | 0 replies | |
| 2/6 | Bluetooth: Break add adv into two mgmt commandsinclude/ include/ net/ | +388 | 0 replies | |
| 3/6 | Bluetooth: Use intervals and tx power from mgmt cmdsinclude/ net/ net/ +1 more | +34 | 0 replies | |
| 4/6 | Bluetooth: Emit tx power chosen on ext adv params completioninclude/ include/ net/ +1 more | +23 | 0 replies | |
| 5/6 | Bluetooth: Query LE tx power on startupinclude/ include/ net/ +1 more | +35 | 0 replies | |
| 6/6 | Bluetooth: Add MGMT command for controller capabilitiesinclude/ net/ | +48 | 0 replies |
Reviews trailers per patch
All 6 patches have a Reviewed-by or Acked-by.
| Patch | Sonny Sasaka |
|---|---|
| 1/6 | R-b |
| 2/6 | R-b |
| 3/6 | R-b |
| 4/6 | R-b |
| 5/6 | R-b |
| 6/6 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/6] Bluetooth: Add new MGMT interface for advertising add
Hi Maintainers,
This patch series defines the new two-call MGMT interface for adding new advertising instances. Similarly to the hci advertising commands, a mgmt call to set parameters is expected to be first, followed by a mgmt call to set advertising data/scan response. The members of the parameters request are optional; the caller defines a "params" bitfield in the structure that indicates which parameters were intentionally set, and others are set to defaults.
The main feature here is the introduction of min/max parameters and tx power that can be requested by the client. Min/max parameters will be used both with and without extended advertising support, and tx power will be used with extended advertising support. After a call for hci advertising parameters, a new TX_POWER_SELECTED event will be emitted to alert userspace to the actual chosen tx power.
Additionally, to inform userspace of the controller LE Tx power capabilities for the client's benefit, this series also adds an MGMT command to query controller capabilities, which returns a flexible TLV format for future flexibility.
All changes have been tested on hatch (extended advertising) and kukui (no extended advertising) chromebooks with manual testing verifying correctness of parameters/data in btmon traces, and our automated test suite of 25 single- and multi-advertising usage scenarios.
A separate patch series will add support in bluetoothd. Thanks in advance for your feedback!
Daniel Winkler
Daniel Winkler (6):
Bluetooth: Add helper to set adv data
Bluetooth: Break add adv into two mgmt commands
Bluetooth: Use intervals and tx power from mgmt cmds
Bluetooth: Emit tx power chosen on ext adv params completion
Bluetooth: Query LE tx power on startup
Bluetooth: Add MGMT command for controller capabilities
include/net/bluetooth/hci.h | 7 + include/net/bluetooth/hci_core.h | 14 +- include/net/bluetooth/mgmt.h | 48 ++++ net/bluetooth/hci_core.c | 47 +++- net/bluetooth/hci_event.c | 22 ++ net/bluetooth/hci_request.c | 29 ++- net/bluetooth/mgmt.c | 420 ++++++++++++++++++++++++++++++- 7 files changed, 561 insertions(+), 26 deletions(-)
Signature · 1 line
2.28.0.618.gf4bc123cb7-goog