Skip to content

Bluetooth: Add new MGMT interface for advertising add

Daniel Winkler linux-bluetooth lkml netdev 12 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest5 patches 2 repliesIn review
  2. v6 posting 2/25 patches 2 repliesSuperseded
  3. v5 posting 2/25 patches 2 repliesSuperseded
Earlier versions · 9
VersionPostedPatchesRepliesStatus
v6 posting 1/210 patches3 repliesApplied
v5 posting 1/210 patches1 replySuperseded
v4 posting 2/25 patches7 repliesSuperseded
v4 posting 1/210 patches7 repliesSuperseded
v3 posting 2/29 patches3 repliesSuperseded
v3 posting 1/25 patches0 repliesSuperseded
v2 posting 2/210 patches3 repliesSuperseded
v2 posting 1/26 patches0 repliesSuperseded
v110 patches5 repliesSuperseded

Changes in v7 from the cover letter

- Rebase onto bluetooth-next/master

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5Bluetooth: Add helper to set adv datainclude/net/bluetooth/hci_core.h net/bluetooth/hci_core.c+34 -01 reply
2/5Bluetooth: Break add adv into two mgmt commandsinclude/net/bluetooth/hci_core.h include/net/bluetooth/mgmt.h net/bluetooth/hci_event.c +1 more+407 -110 replies
3/5Bluetooth: Use intervals and tx power from mgmt cmdsinclude/net/bluetooth/hci_core.h net/bluetooth/hci_core.c net/bluetooth/hci_request.c +1 more+34 -160 replies
4/5Bluetooth: Query LE tx power on startupinclude/net/bluetooth/hci.h include/net/bluetooth/hci_core.h net/bluetooth/hci_core.c +1 more+35 -00 replies
5/5Bluetooth: Change MGMT security info CMD to be more genericinclude/net/bluetooth/mgmt.h net/bluetooth/mgmt.c+39 -190 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchSonny Sasaka
1/5R-b
2/5R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v7 thread

Cover letter [PATCH v7 0/5] Bluetooth: Add new MGMT interface for advertising add

Hi Maintainers,

This patch series defines the new two-call MGMT interface for adding new advertising instances. Similarly to the hci advertising commands, a mgmt call to set parameters is expected to be first, followed by a mgmt call to set advertising data/scan response. The members of the parameters request are optional; the caller defines a "params" bitfield in the structure that indicates which parameters were intentionally set, and others are set to defaults.

The main feature here is the introduction of min/max parameters and tx power that can be requested by the client. Min/max parameters will be used both with and without extended advertising support, and tx power will be used with extended advertising support. After a call to set advertising parameters, the selected transmission power will be propagated in the reponse to alert userspace to the actual power used.

Additionally, to inform userspace of the controller LE Tx power capabilities for the client's benefit, this series also changes the security info MGMT command to more flexibly contain other capabilities, such as LE min and max tx power.

All changes have been tested on hatch (extended advertising) and kukui (no extended advertising) chromebooks with manual testing verifying correctness of parameters/data in btmon traces, and our automated test suite of 25 single- and multi-advertising usage scenarios.

A separate patch series will add support in bluetoothd. Thanks in advance for your feedback!

Daniel Winkler

Changes in v7:
- Rebase onto bluetooth-next/master

Changes in v6:
- Only populate LE tx power range if controller reports it

Changes in v5:
- Ensure data/scan rsp length is returned for non-ext adv

Changes in v4:
- Add remaining data and scan response length to MGMT params response
- Moving optional params into 'flags' field of MGMT command
- Combine LE tx range into a single EIR field for MGMT capabilities cmd

Changes in v3:
- Adding selected tx power to adv params mgmt response, removing event
- Re-using security info MGMT command to carry controller capabilities

Changes in v2:
- Fixed sparse error in Capabilities MGMT command

Daniel Winkler (5):
Bluetooth: Add helper to set adv data
Bluetooth: Break add adv into two mgmt commands
Bluetooth: Use intervals and tx power from mgmt cmds
Bluetooth: Query LE tx power on startup
Bluetooth: Change MGMT security info CMD to be more generic

 include/net/bluetooth/hci.h      |   7 +
 include/net/bluetooth/hci_core.h |  12 +-
 include/net/bluetooth/mgmt.h     |  49 +++-
 net/bluetooth/hci_core.c         |  47 +++-
 net/bluetooth/hci_event.c        |  19 ++
 net/bluetooth/hci_request.c      |  29 ++-
 net/bluetooth/mgmt.c             | 430 +++++++++++++++++++++++++++++--
 7 files changed, 548 insertions(+), 45 deletions(-)
Signature · 1 line
2.29.2.576.ga3fc446d84-goog