Skip to content

drm/ttm: bind/unbind + cleanups

Dave Airlie dri-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7drm/ttm: protect against reentrant bind in the driversdrivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c drivers/gpu/drm/nouveau/nouveau_bo.c drivers/gpu/drm/nouveau/nouveau_sgdma.c +10 more+91 -451 reply
2/7drm/ttm: flip tt destroy ordering.drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c drivers/gpu/drm/drm_gem_vram_helper.c drivers/gpu/drm/nouveau/nouveau_bo.c +6 more+22 -11 reply
3/7drm/ttm: move unbind into the tt destroy.drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c drivers/gpu/drm/nouveau/nouveau_bo.c drivers/gpu/drm/nouveau/nouveau_sgdma.c +3 more+6 -11 reply
4/7drm/ttm/drivers: call the bind function directly.drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c drivers/gpu/drm/nouveau/nouveau_bo.c drivers/gpu/drm/radeon/radeon_ttm.c +1 more+14 -41 reply
5/7drm/ttm: add a simple assign mem to bo wrapperdrivers/gpu/drm/ttm/ttm_bo_util.c include/drm/ttm/ttm_bo_driver.h+14 -141 reply
6/7drm/ttm: move ghost object creation to a common functiondrivers/gpu/drm/ttm/ttm_bo_util.c+43 -621 reply
7/7drm/ttm: make common function for wait/free node path.drivers/gpu/drm/ttm/ttm_bo_util.c+20 -181 reply

Reviews trailers per patch

5 of 7 patches have a Reviewed-by or Acked-by.

PatchChristian König
1/7
2/7R-b
3/7R-b
4/7R-b
5/7R-b
6/7
7/7R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/7] drm/ttm: bind/unbind + cleanups

I've pulled a few of the cleaner bits of rework out for review.

The first thing is to move all the tt bind tracking into the driver so the core doesn't do it all anymore. Once that is done it's possible to flip over how destroy works so the drivers call some common code instead of vice-versa.

With those two done the unbind can be completely moved into drivers, so it happens before the unpopulate in the common code. This removes a lot of unbinds from the core code (only really one left).

Then a patch to flip some drivers over to direct calling their bind functions instead of indirect (just a trivial cleanup really) (bind needs a lot more work).

Then I just refactored out some common patters in the move code, which should make it easier to pinpoint the codeflow for future bind changes.

Dave.

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel