Skip to content

Upgrade HAL and add ENI metrics support

Michal Krawczyk dpdk-dev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest20 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/20net/ena/base: use min/max macros with type conversiondrivers/net/ena/base/ena_plat_dpdk.h+8 -60 replies
2/20net/ena/base: specify operations of rte_delaydrivers/net/ena/base/ena_plat_dpdk.h+2 -20 replies
3/20net/ena/base: support 'resource busy' admin statusdrivers/net/ena/base/ena_com.c+2 -00 replies
4/20net/ena/base: exponential delay in polling functionsdrivers/net/ena/base/ena_com.c drivers/net/ena/base/ena_com.h drivers/net/ena/base/ena_plat_dpdk.h+29 -100 replies
5/20net/ena/base: fix release of wait eventdrivers/net/ena/base/ena_com.c+4 -20 replies
6/20net/ena/base: remove MMIOWB_NOT_DEFINED ifdefdrivers/net/ena/base/ena_com.c+0 -20 replies
7/20net/ena/base: rework setup of accelerated LLQ modedrivers/net/ena/base/ena_com.c drivers/net/ena/base/ena_eth_com.h+11 -120 replies
8/20net/ena/base: add ENI statsdrivers/net/ena/base/ena_com.c drivers/net/ena/base/ena_com.h drivers/net/ena/base/ena_defs/ena_admin_defs.h+62 -30 replies
9/20net/ena/base: split RSS function and hash gettersdrivers/net/ena/base/ena_com.c drivers/net/ena/base/ena_com.h+43 -140 replies
10/20net/ena/base: do not use hardcoded RSS key buffer sizedrivers/net/ena/base/ena_com.c drivers/net/ena/base/ena_defs/ena_admin_defs.h+6 -50 replies
11/20net/ena/base: check for RSS key configuration supportdrivers/net/ena/base/ena_com.c drivers/net/ena/base/ena_defs/ena_admin_defs.h+24 -40 replies
12/20net/ena/base: minor style adjustmentsdrivers/net/ena/base/ena_com.c drivers/net/ena/base/ena_com.h drivers/net/ena/base/ena_defs/ena_eth_io_defs.h +3 more+8 -110 replies
13/20net/ena/base: add missing unlikelydrivers/net/ena/base/ena_com.c+1 -10 replies
14/20net/ena/base: store admin stats as u64drivers/net/ena/base/ena_com.h+5 -50 replies
15/20net/ena/base: add check for meta desc being NULLdrivers/net/ena/base/ena_eth_com.c+3 -00 replies
16/20net/ena/base: convert values to u32 before shiftingdrivers/net/ena/base/ena_eth_com.c+7 -70 replies
17/20net/ena/base: simplify loop copying Rx descsdrivers/net/ena/base/ena_eth_com.c+9 -40 replies
18/20net/ena/base: update generation date and commitdrivers/net/ena/base/ena_defs/ena_gen_info.h+2 -20 replies
19/20net/ena: lock dynamic usages of the admin queuedrivers/net/ena/ena_ethdev.c drivers/net/ena/ena_ethdev.h+16 -00 replies
20/20net/ena: expose ENI stats as additional xstatsdrivers/net/ena/ena_ethdev.c drivers/net/ena/ena_ethdev.h+102 -20 replies

Reviews trailers per patch

All 20 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchIgor ChauskinGuy TzalikStephen Hemminger
SeriesR-b
1/20R-b R-b
2/20R-b R-b
3/20R-b R-b
4/20R-b R-b
5/20R-b R-b
6/20R-b R-b
7/20R-b R-b
8/20R-b R-b
9/20R-b R-b
10/20R-b R-b
11/20R-b R-b
12/20R-b R-b
13/20R-b R-b
14/20R-b R-b
15/20R-b R-b
16/20R-b R-b
17/20R-b R-b
18/20R-b R-b
19/20R-b R-b
20/20R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [dpdk-dev] [PATCH 00/20] Upgrade HAL and add ENI metrics support

Hi,

this patchset contains upgrade of the of the HAL, which, beside some fixes, also adds possibility for reading ENI metrics from the device.

Those are further exposed to the DPDK applicaiton using xstats.

As it's an extra call to the admin queue during a PMD runtime, for multithread safet the locks had to be added around those functions.

Michal Krawczyk (20):
net/ena/base: use min/max macros with type conversion net/ena/base: specify operations of rte_delay net/ena/base: support 'resource busy' admin status net/ena/base: exponential delay in polling functions net/ena/base: fix release of wait event net/ena/base: remove MMIOWB_NOT_DEFINED ifdef net/ena/base: rework setup of accelerated LLQ mode net/ena/base: add ENI stats
net/ena/base: split RSS function and hash getters net/ena/base: do not use hardcoded RSS key buffer size net/ena/base: check for RSS key configuration support net/ena/base: minor style adjustments net/ena/base: add missing unlikely net/ena/base: store admin stats as u64 net/ena/base: add check for meta desc being NULL net/ena/base: convert values to u32 before shifting net/ena/base: simplify loop copying Rx descs net/ena/base: update generation date and commit net/ena: lock dynamic usages of the admin queue net/ena: expose ENI stats as additional xstats

 drivers/net/ena/base/ena_com.c                | 137 ++++++++++++------
 drivers/net/ena/base/ena_com.h                |  57 ++++++--
 .../net/ena/base/ena_defs/ena_admin_defs.h    |  56 ++++++-
 .../net/ena/base/ena_defs/ena_eth_io_defs.h   |   3 +-
 drivers/net/ena/base/ena_defs/ena_gen_info.h  |   5 +-
 drivers/net/ena/base/ena_defs/ena_regs_defs.h |   3 +-
 drivers/net/ena/base/ena_eth_com.c            |  34 +++--
 drivers/net/ena/base/ena_eth_com.h            |   2 +-
 drivers/net/ena/base/ena_plat_dpdk.h          |  19 ++-
 drivers/net/ena/ena_ethdev.c                  |  86 ++++++++++-
 drivers/net/ena/ena_ethdev.h                  |  34 +++++
 11 files changed, 344 insertions(+), 92 deletions(-)
Signature · 1 line
2.25.1